[OMPT-svn-commit] SF.net SVN: modplug:[745] trunk/OpenMPT/mptrack/AbstractVstEditor.cpp

[<sag...@us...>]

Revision: 745
          http://modplug.svn.sourceforge.net/modplug/?rev=745&view=rev
Author:   saga-games
Date:     2010-10-22 14:24:48 +0000 (Fri, 22 Oct 2010)

Log Message:
-----------
[Mod] VST Editor: When automatically inserting a new instrument, the bank and patch values are now not filled in anymore, so it is easier to change to another patch while editing.

Modified Paths:
--------------
    trunk/OpenMPT/mptrack/AbstractVstEditor.cpp

Modified: trunk/OpenMPT/mptrack/AbstractVstEditor.cpp
===================================================================
--- trunk/OpenMPT/mptrack/AbstractVstEditor.cpp	2010-10-22 14:24:19 UTC (rev 744)
+++ trunk/OpenMPT/mptrack/AbstractVstEditor.cpp	2010-10-22 14:24:48 UTC (rev 745)
@@ -380,8 +380,9 @@
 			strncpy(pIns->filename, pSndFile->m_MixPlugins[m_pVstPlugin->GetSlot()].Info.szLibraryName, ARRAYELEMCOUNT(pIns->filename) - 1);
 			pIns->nMixPlug = (PLUGINDEX)m_pVstPlugin->GetSlot() + 1;
 			pIns->nMidiChannel = 1;
-			pIns->wMidiBank = (WORD)((m_pVstPlugin->GetCurrentProgram() >> 7) + 1);
-			pIns->nMidiProgram = (BYTE)((m_pVstPlugin->GetCurrentProgram() & 0x7F) + 1);
+			// People will forget to change this anyway, so the following lines can lead to some bad surprises after re-opening the module.
+			//pIns->wMidiBank = (WORD)((m_pVstPlugin->GetCurrentProgram() >> 7) + 1);
+			//pIns->nMidiProgram = (BYTE)((m_pVstPlugin->GetCurrentProgram() & 0x7F) + 1);
 
 			pModDoc->UpdateAllViews(NULL, (nIns << HINT_SHIFT_INS) | HINT_INSTRUMENT | HINT_INSNAMES | HINT_ENVELOPE | (bFirst ? HINT_MODTYPE : 0));
 			if(pSndFile->GetModSpecifications().supportsPlugins)


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.