Probably none yet, but 36 is probably incorrect value. At least gcc reports on x86_64:
inlined from 'BOOL PAT_Load_Instruments(void*)' at load_pat.cpp:1321:
/usr/include/bits/string3.h:122: warning: call to char* __builtin___strncpy_chk(char*, const char*, long unsigned int, long unsigned int) will
always overflow destination buffer
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Yeah, I see it now - there are several reserved - this one is of size 32.
And 32 is used correctly in the 2 times below this line.
(So therefore this problem should affect all platforms)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
libmodplug-0.8.6-buffer_overflow.patch
The patch is applied in CVS.
What kind of platform has char != int8_t ?
Probably none yet, but 36 is probably incorrect value. At least gcc reports on x86_64:
inlined from 'BOOL PAT_Load_Instruments(void*)' at load_pat.cpp:1321:
/usr/include/bits/string3.h:122: warning: call to char* __builtin___strncpy_chk(char*, const char*, long unsigned int, long unsigned int) will
always overflow destination buffer
Yeah, I see it now - there are several reserved - this one is of size 32.
And 32 is used correctly in the 2 times below this line.
(So therefore this problem should affect all platforms)