#17 suspicious discrepancy in load_med.cpp between 0.8.8.4 and git repo

[Ozkan Sezer]

The last change to load_med.cpp in the git repo is 10fddf:
http://sourceforge.net/p/modplug-xmms/git/ci/10fddff0a4c00131da6c0dd7c56720cfa347c75f/

However, a diff of libmodplug 0.8.8.3 and 0.8.8.4 shows an additional
change in ReadMed() :

--- libmodplug-0.8.8.3/src/load_med.cpp 2011-05-01 06:34:21.000000000 +0300
+++ libmodplug-0.8.8.4/src/load_med.cpp 2011-08-04 14:58:55.000000000 +0300
@@ -684,11 +691,11 @@ BOOL CSoundFile::ReadMed(const BYTE *lpS
if (pmex)
{
// Channel Split
- if ((m_nChannels == 4) && (pmsh->flags & 0x40))
+ if ((m_nChannels == 4) && (pmsh->flags & MMD_FLAG_8CHANNEL))
{
for (UINT i8ch=0; i8ch<4; i8ch++)
{
- if (pmex->channelsplit[i8ch]) m_nChannels++;
+ if (pmex->channelsplit[i8ch]) --m_nChannels;
}
}
// Song Comments

MMD_FLAG_8CHANNEL is 0x40, that's OK I guess, but the next line changes
m_nChannels incrementing into decrementing: is this intentional?

[Konstanty]

That's quite terrible that I released that into 0.8.8.4 but didn't write the commit.

The second part was due to some testing to make a certain MED file play "better". It still wasn't perfect though. There was a more major bit of logic that needed changing.

[Ozkan Sezer]

I see. Should I stick to 0.8.8.4 release or to -git, then?