AtlasProgress fix size and unlocalized String
Brought to you by:
r_x
Hi @r_x,
I just remarked that AtlasProgress had 2 little visual defects (see png attached)
- unlocalized String dlg_download_window_title
appear on top of popup body
- height is too short to completely render bottom action buttons (maybe due to first point)
Here is my quick patch, but surely not the good way to fix it
--- mobac/src/main/java/mobac/gui/AtlasProgress.java (revision 2653) +++ mobac/src/main/java/mobac/gui/AtlasProgress.java (working copy) @@ -132,7 +132,7 @@ createComponents(); // Initialize the layout in respect to the layout (font size ...) pack(); - setMinimumSize(new Dimension(getWidth(), getHeight())); + setMinimumSize(new Dimension(getWidth(), getHeight()+20)); guiUpdater.run(); @@ -232,7 +232,7 @@ GBC gbcEolFill = GBC.eol().fill(GBC.HORIZONTAL); GBC gbcEolFillI = GBC.eol().fill(GBC.HORIZONTAL).insets(0, 5, 0, 0); - background.add(windowTitle, gbcEolFill); + //background.add(windowTitle, gbcEolFill); background.add(Box.createVerticalStrut(10), gbcEol); background.add(mapInfoLabel, gbcEolFill);
Thanks for the path. I have accepted the height increase but rejected the removal of the
windowTitle
field. I don't see a point in removing an UI element just because the French translation is missing.Instead I fixed the string resource loading so that in case of missing localized strings the string from the English/US locale is used. Not sure why this was not working, I thought that this fallback was once functional.
As I see, it's present... Maybe a encoding issue with 'É'?
mobac/src/main/resources/mobac/resources/text/localize_fr_FR.properties:302:#dlg_download_window_title=<html><h3>CRÉATION DE L'ATLAS EN COURS...</h3></html>
Note the hash at the beginning this disables the entry.
Ticket moved from /p/mobac/bugs/364/