Menu
▾
▴
[MLton-commit] [MLton/mlton] feca6e: Add `scan.string.sml` test demonstrating minor bug...
|
From: 'Matthew F. v. MLton-c. <mlt...@ml...> - 2026-09-30 15:27:36
|
Branch: refs/heads/master Home: https://github.com/MLton/mlton Commit: feca6e1f9ec66defcdd0b8cae9134af0e27794ac https://github.com/MLton/mlton/commit/feca6e1f9ec66defcdd0b8cae9134af0e27794ac Author: Matthew Fluet <mat...@gm...> Date: 2026-09-29 (Tue, 29 Sep 2026) Changed paths: A regression/string.scan.ok A regression/string.scan.sml Log Message: ----------- Add `scan.string.sml` test demonstrating minor bugs with `String.fromCString` See MLton/mlton#658 Commit: 8e5a13e11833f71d29f7a7e8efae692cdc95a633 https://github.com/MLton/mlton/commit/8e5a13e11833f71d29f7a7e8efae692cdc95a633 Author: Matthew Fluet <mat...@gm...> Date: 2026-09-29 (Tue, 29 Sep 2026) Changed paths: M basis-library/text/char.sig M basis-library/text/char.sml M basis-library/text/string.sml Log Message: ----------- Rename Basis Library format sequence helpers for `structure Char` Commit: 2faf1d78dcd4a6dbe6d3f2d84b6b0f4d0b79f643 https://github.com/MLton/mlton/commit/2faf1d78dcd4a6dbe6d3f2d84b6b0f4d0b79f643 Author: Matthew Fluet <mat...@gm...> Date: 2026-09-29 (Tue, 29 Sep 2026) Changed paths: M CHANGELOG.adoc M basis-library/text/string.sml Log Message: ----------- Fix bug in `String.fromCString` when first character cannot be converted The implementation of `String.fromCString` did not confirm that at least a single C-string character could be consumed from the input string and would return `SOME ""` on an input string whose first character could not be converted (e.g., illegal escape). Closes MLton/mlton#658 Also, unify the implementations of `String.fromString` and `String.fromCString` to share the logic for converting an initial character and converting the remaining characters. Commit: 018425b7272e72992698de3cd5df4afbbf8b9a30 https://github.com/MLton/mlton/commit/018425b7272e72992698de3cd5df4afbbf8b9a30 Author: Matthew Fluet <mat...@gm...> Date: 2026-09-29 (Tue, 29 Sep 2026) Changed paths: M regression/char.scan.ok M regression/char.scan.sml Log Message: ----------- Update `char.scan.sml` with test for formatting escape after escape Commit: cbe9577142dfa2ba4713dbcd7bc1ca20bd142b8f https://github.com/MLton/mlton/commit/cbe9577142dfa2ba4713dbcd7bc1ca20bd142b8f Author: Matthew Fluet <mat...@gm...> Date: 2026-09-29 (Tue, 29 Sep 2026) Changed paths: M CHANGELOG.adoc M basis-library/text/char.sml Log Message: ----------- Fix bug in `Char.scan` with escaped formatting following escape The Basis Library specification for `Char.scan` states: "As the table indicates, escaped formatting sequences (`\f...f\`) are passed over during scanning. Such sequences are successfully scanned, so that the remaining stream returned by scan will never have a valid escaped formatting sequence as its prefix." `Char.scan` ran `skipFormatSequences` on the state after the successful scan of a non-escape character, but did not on the state after the successful scan of a non-escaped-formatting-sequence escape sequence. Commit: 08653801fb64b6e8efd5fb42f06dd67bb5edf2b8 https://github.com/MLton/mlton/commit/08653801fb64b6e8efd5fb42f06dd67bb5edf2b8 Author: Matthew Fluet <mat...@gm...> Date: 2026-09-29 (Tue, 29 Sep 2026) Changed paths: M basis-library/text/char.sml Log Message: ----------- Drop unnecessary val rec Commit: 7ff4e52a7079e069a9cbf18c4e33db3648a40b40 https://github.com/MLton/mlton/commit/7ff4e52a7079e069a9cbf18c4e33db3648a40b40 Author: Matthew Fluet <mat...@gm...> Date: 2026-09-29 (Tue, 29 Sep 2026) Changed paths: M regression/string.sml Log Message: ----------- Update `regression/string.sml` to properly check failing String.fromCString conversions Commit: 60f1593048f75a06e54b4b594e19b7b2f435b7ff https://github.com/MLton/mlton/commit/60f1593048f75a06e54b4b594e19b7b2f435b7ff Author: Matthew Fluet <mat...@gm...> Date: 2026-09-29 (Tue, 29 Sep 2026) Changed paths: M regression/string.scan.ok M regression/string.scan.sml Log Message: ----------- Additional tests in `regression/string.scan.sml` Commit: 95049a906ed08b9b4e92c73340d43cf8e5111e07 https://github.com/MLton/mlton/commit/95049a906ed08b9b4e92c73340d43cf8e5111e07 Author: Matthew Fluet <mat...@gm...> Date: 2026-09-30 (Wed, 30 Sep 2026) Changed paths: M CHANGELOG.adoc M basis-library/text/char.sml M regression/widechar.sml Log Message: ----------- Don't accept `\uxxxx` and `\Uxxxxxxxx` escape sequences in C strings Commit: 936011ca7acd41461bf9ed806c94c9b1a621a288 https://github.com/MLton/mlton/commit/936011ca7acd41461bf9ed806c94c9b1a621a288 Author: Matthew Fluet <Mat...@gm...> Date: 2026-09-30 (Wed, 30 Sep 2026) Changed paths: M CHANGELOG.adoc M basis-library/text/char.sig M basis-library/text/char.sml M basis-library/text/string.sml M regression/char.scan.ok M regression/char.scan.sml A regression/string.scan.ok A regression/string.scan.sml M regression/string.sml M regression/widechar.sml Log Message: ----------- Merge pull request #659 from MatthewFluet/text-scan-bugs * Fix bug in `String.fromCString` that would return `SOME ""` on an input string whose first character could not be converted (e.g., illegal escape). Thanks to Ruud Koot (ruudkoot), via Claude, for the bug report. (Closes MLton/mlton#658) * Fix bug in `Char.scan` that would fail to consume escaped formatting sequences following a non-escaped-formatting-sequence escape sequence. * Fix bug in `Char.fromCString` and `String.fromCString` that would erroneously accept `\uxxxx` and `\Uxxxxxxxx` escape sequences. Compare: https://github.com/MLton/mlton/compare/aa2fd1ad9b91...936011ca7acd To unsubscribe from these emails, change your notification settings at https://github.com/MLton/mlton/settings/notifications To unsubscribe from this group and stop receiving emails from it, send an email to mlt...@ml.... |
