Menu

#78 pointer issues

v1.0 (example)
open
nobody
None
5
2020-01-18
2018-08-24
Petr Gajdos
No

There is following issue in im_canna.c:

[   31s] im_canna.c:308:36: warning: passing argument 3 of 'jrKanjiControl' makes pointer from integer without a cast [-Wint-conversion]
[   31s]      jrKanjiControl(0, KC_SETWIDTH, 60);
[   31s]                                     ^~

and following issues in ui_window_cairo.c:

[   27s] ui_window_cairo.c: In function 'flush_glyphs':
[   27s] ui_window_cairo.c:57:44: warning: passing argument 2 of 'cairo_get_user_data' makes pointer from integer without a cast [-Wint-conversion]
[   27s]      u_long pixel = cairo_get_user_data(cr, 2);
[   27s]   

(and similar) and

[   27s] ui_window_cairo.c:132:25: warning: passing argument 3 of 'cairo_set_user_data' makes pointer from integer without a cast [-Wint-conversion]
[   27s]                          (u_long)((fg_color->red << 16) | (fg_color->green << 8) |
[   27s]                                   (fg_color->blue) | (fg_color->alpha << 24)),

Discussion

  • Petr Gajdos

    Petr Gajdos - 2018-08-24

    Patch that could resolve these issue, but please review thoroughly.

     
  • Petr Gajdos

    Petr Gajdos - 2018-08-24

    Ah, I see .. the patch above is obviously wrong.

     
  • Petr Gajdos

    Petr Gajdos - 2018-08-24

    This could be better. As it seems to be merely casting issue, I would not object against WONTFIX.

     
  • Petr Gajdos

    Petr Gajdos - 2019-12-19

    Hey, could you please react, somehow ..

     
  • Petr Gajdos

    Petr Gajdos - 2019-12-19

    Patch against 3.8.9.

     
  • Araki Ken

    Araki Ken - 2020-01-18

    Sorry for my late reply.
    Thanks for your patch.
    I've merged it.

     

Log in to post a comment.