Re: [Mlt-devel] On Removing SDL 1.2

[Janne L. <jan...@gm...>]

> I do Not drop anything on my own,

Great.

> but If SDL people say they do Not Support and Develop this very old technology anymore and people should move to the new Interfaces I couldnt do much against it, also why?

They are 100% not going to develop it any further or support it, but
that is not a problem, existing code will keep working, and if it for
some reason stops working, well, then that's it, then you can and
should remove it. But as long as it offers this functionality for
Flowblade it has value.

> They offer a compability layer, very nice from them!but they also want to get rid of this old Code base, you understand?

I'll look into the compatibility layer, and will give getting SDL2
video display over widget working another go. Maybe it will work this
time.


On Sat, Jun 24, 2023 at 7:52 PM Patrick Matthäi <pa...@li...> wrote:
>
> I do Not drop anything on my own,but If SDL people say they do Not Support and Develop this very old technology anymore and people should move to the new Interfaces I couldnt do much against it, also why?
> They offer a compability layer, very nice from them!but they also want to get rid of this old Code base, you understand?
>
>
>
> Am 24.06.2023 17:14 schrieb Janne Liljeblad <jan...@gm...>:
>
> Why are you dropping anything? "Obsolete" is good here, the whole
> stack from SDL 1.2 to X11 is as frozen as methane on Pluto. It will
> keep functioning just like before as long as X11 or maybe XWayland is
> working.
>
> There are no additional maintenance costs precisely because SDL 1.2 is
> so much behind the curve and nothing changes. SDL2 is also done now so
> what is the point in moving from one old codebase to another just to
> get exactly the same functionality.
>
> Anyway, I hope you keep SDL 1.2 as long as possible.
>
> On Sat, Jun 24, 2023 at 5:54 PM Patrick Matthäi <pa...@li...> wrote:
> >
> > Hi,
> >
> > If something does Not Work AS excepted IT could be a Bug. IT seems you are complete into this topic so i think IT would BE nice to contact the SDL developers about it to find a solution?
> > I could keep the 1.2 compability for a short time, but also after that time 1.2 Support will get removed and flowblade needs a solution
> >
> > Sorry for this lame Format, i am writing from my smartphone
> >
> > Am 24.06.2023 15:25 schrieb Janne Liljeblad <jan...@gm...>:
> >
> > So SDL 2 has function:
> >
> > SDL_Window * SDL_CreateWindowFrom(const void *data);
> >
> > which ends up calling:
> >
> > X11_CreateWindowFrom(_THIS, SDL_Window * window, const void *data)
> >
> > but this code path just never worked for the purpose of attaching
> > video display to a Gtk widget X11 window. Everything initialized and
> > run well on MLT and SDL2 on the consumer I created, but no video got
> > displayed ever.
> >
> > On Sat, Jun 24, 2023 at 3:49 PM Janne Liljeblad
> > <jan...@gm...> wrote:
> > >
> > > Flowblade uses MLT SDL 1.2 functions. Below is how Flowblade displays video.
> > >
> > >         # Create consumer and set params
> > >         self.consumer = mlt.Consumer(self.profile, "sdl")
> > >
> > > I've several times tried to create a SDL 2 video consumer for MLT that
> > > displays video on top of Gtk.VBox widget Flowblade uses toi display
> > > video, no dice.
> > >
> > > On Sat, Jun 24, 2023 at 3:42 PM Patrick Matthäi <pa...@li...> wrote:
> > > >
> > > > Hey
> > > > But it is flowblade itself using SDL 1.2 or using the mlt SDL 1.2 functions?
> > > >
> > > > Am 24.06.2023 14:15 schrieb Janne Liljeblad <jan...@gm...>:
> > > >
> > > > Flowblade needs SDL 1.2 for video display and there is no clear path
> > > > forward for replacement known to me.
> > > >
> > > > The problem is the piece of code in SDL 1.2 below. That functionality
> > > > has not worked SDL 2.0 when I have tried to get it to display video.
> > > > SDL 2 only allows creating new windows for video display, not display
> > > > video on top of some X11 window that is connected to the widget
> > > > Flowblade uses to show video.
> > > >
> > > > ---
> > > > static int X11_CreateWindow(_THIS, SDL_Surface *screen,
> > > >                 int w, int h, int bpp, Uint32 flags)
> > > > {
> > > >     int i, depth;
> > > >     Visual *vis;
> > > >     int vis_change;
> > > >     Uint32 Amask;
> > > >
> > > >     /* If a window is already present, destroy it and start fresh */
> > > >     if ( SDL_Window ) {
> > > >         X11_DestroyWindow(this, screen);
> > > >         switch_waiting = 0; /* Prevent jump back to now-meaningless state. */
> > > >     }
> > > >
> > > >     /* See if we have been given a window id */
> > > >     if ( SDL_windowid ) {
> > > >         SDL_Window = SDL_strtol(SDL_windowid, NULL, 0);
> > > >     } else {
> > > >         SDL_Window = 0;
> > > >     }
> > > > ...
> > > > ---
> > > >
> > > > this is from SDL-1.2/src/video/x11/SDL_x11video.c
> > > >
> > > > I don't think this is ever going to work in SDL2 because Wayland does
> > > > not have window ids for widgets. For Flowblade it is best to keep SDL
> > > > 1.2 to display video for X11 and find another solution for Wayland.
> > > >
> > > > Janne
> > > >
> > > >
> > > > _______________________________________________
> > > > Mlt-devel mailing list
> > > > Mlt...@li...
> > > > https://lists.sourceforge.net/lists/listinfo/mlt-devel
> > > >
> > > >
> >
> >
>
>