Re: [Mlt-devel] [PATCH] fix thread exit on error and thread termination
Brought to you by:
ddennedy,
lilo_booter
From: Maksym V. <ve...@m1...> - 2012-02-08 10:34:14
|
08.02.12 06:19, Dan Dennedy написав(ла): >> 2012/1/16 Maksym Veremeyenko<ve...@m1...>: >>> wrong test code where mlt_consumer_stop was called immediately after >>> mlt_consumer_start caused that sideeffect. >>> >>> to resolve such condition i attached a patch that properly determinate >>> consumer's thread finish and avoid writing /trailer/ if no /header was >>> written.. > > My testing with sdl and decklink consumers showed that they were not > vulnerable to this, but indeed avformat was. I resolved this a little > differently, and committed it. > the goal of that patch was to disable setting/altering flag /running/ inside thread - that could cause some leaks and some race condition i notified about... -- ________________________________________ Maksym Veremeyenko |