Re: [Mlt-devel] Crash & compile issues with videostab filter

[Dan D. <da...@de...>]

On Mon, Jan 2, 2012 at 12:53 PM, j-b-m <j-...@us...> wrote:
> On Sunday 01 January 2012 14:22:52 Dan Dennedy wrote:
>> On Sun, Jan 1, 2012 at 1:50 PM, j-b-m <j-...@us...> wrote:
>> > Hello there!
>> >
>> > There are a few problems with the videostab module that currently make it
>> > unusable in Kdenlive.
>> >
>> > First, the filter crashes if more than one instance is used, because of
>> > the
>> > way lanc_kernel is used.
>> >
>> > This is reproducible for me with:
>> >
>> > melt stab.mlt stab.mlt
>> >
>> > (stab.mlt being a stabilized clip, playing it twice brings the crash).
>> >
>> > The crash happens when quitting melt, trying to close the 2 instances of
>> > the
>> > filter creates a double free corruption crash on lanc_kernel:
>> marco, it would be nice if you can take a look at this one. I just
>> fixed the build problem.
>
> Hi Dan & Marco.
>
> Thanks for your quick feedback. The build problem is not yet solved, the
> simple patch below is required to make Dan's fix useful.

thanks. easy mistake since I could not reproduce the problem on my
typical systems. What distro+version did you experience that?

> I did a quick test with Marco's recent changes and it seems to work in
> Kdenlive now, great.
>
> regards
>
>
> diff --git a/src/modules/videostab/Makefile b/src/modules/videostab/Makefile
> index 38167d0..c6b45fd 100644
> --- a/src/modules/videostab/Makefile
> +++ b/src/modules/videostab/Makefile
> @@ -1,3 +1,5 @@
> +include ../../../config.mak
> +
>  CFLAGS += -I../..
>  ifdef SSE2_FLAGS
>  CFLAGS += -msse2
> @@ -5,7 +7,6 @@ endif
>
>  LDFLAGS += -L../../framework -lmlt -lm
>
> -include ../../../config.mak
>
>  TARGET = ../libmltvideostab$(LIBSUF)
>

-- 
+-DRD-+