Re: [Mlt-devel] MLT: xlocale.h in FreeBSD 10

[Dan D. <da...@de...>]

2011/12/22 Gleb Smirnoff <gl...@gl...>:
> On Wed, Dec 21, 2011 at 09:48:32PM -0800, Dan Dennedy wrote:
> D> Thanks, Gleb. The patch is applied to git now.
>
> Thanks, Dan!
>
> btw, concerning my bug report:
>
> http://sourceforge.net/tracker/?func=detail&atid=613414&aid=3441193&group_id=96039
>
> I've found that the mlt framework uses char when obtaining values
> from xml. Here is attached my ~/.openshot/sequence.mlt which causes
> crash. Yes, I understand that in 2012 everyone should run UTF-8 on their
> filesystems, but I still use koi8-r. I think that using 'unsigned char'
> instead of 'char' throughout mlt_properties.c and mlt_property.c for the
> property values would fix the problem. However, I didn't tried that.
>
> What do you think on this?

I do not think It is not as simple as switching to unsigned char. The
problem is that something needs to convert from the locale encoding to
the encoding used in the XML. At that point one can just coerce the
char* to unsigned char* if needed. But I do not yet know if that is
done with a libxml2 function or if needs to done prior to that with
iconv.

-- 
+-DRD-+