Re: [Mlt-devel] New Filter Submission: dynamictext
Brought to you by:
ddennedy,
lilo_booter
From: Dan D. <da...@de...> - 2011-09-21 05:13:08
|
On Tue, Sep 20, 2011 at 5:36 PM, Brian Matherly <pez...@ya...> wrote: > Hi Dan, > > Did you have an opportunity to review the commit below? yes, merged now > >>> Thank you! I have one more thing. I want to move it to the gtk2 module >>> because it depends on pango. While it also depends on watermark and >>> composite, those are in the core module, which has no external >>> dependencies whereas there very well can be builds that do not include >>> gtk2 (or its linkage is broken). >> >>No problem. I squashed them all into one commit to make it easy for you: >>https://github.com/pez4brian/mlt/commit/7f5034480306a8d55e164127f903a27640048373 > > > It includes three commits all squashed into one. Those commits include: > * The original filter submission > > * The changes to resolve your first set of comments > * The change to move the filter into gtk2 per your last request. > > Let me know if you have any other comments/concerns. > > Regards, > > ~Brian > > -- +-DRD-+ |