Re: [Mlt-devel] [PATCH] migrate to timestamped audio packet

[Maksym V. <ve...@m1...>]

10.06.11 08:43, Dan Dennedy написав(ла):
> On Thu, Jun 9, 2011 at 12:33 PM, Maksym Veremeyenko<ve...@m1...>  wrote:
>> On Thu, June 9, 2011 7:27 pm, Dan Dennedy wrote:
>> [...]
>>> frame that is being saved and repeated, hmm... repeat last
>>> DeckLinkVideoFrame instead of mlt_frame.
>> great idea!
>>
>> what would you say about approach used in attached patch? I will test it
>> tomorrow morning...
>
> Yes, that is good. One small thing, in stop(), after releasing
> m_decklinkFrame, you need to set it to NULL.
updated patch attached...

> Testing the overall
> change, it works fairly good, but I am able to make the audio play
> intermittently: 1 sec audio, 2 sec silence, repeat. I reproduce it by
> setting up melted for SD, loading a HD clip, scrub a bit, play, and
> maybe scrub some more until it happens. Of course, stop followed by
> play resolves it. Can you reproduce it?
>
i reproduced it easy - good catch..

this actually happens on attempt to ScheduleNextFrame if callback status 
is bmdOutputFrameDisplayedLate and as result (IMHO) audio samples has 
timestamp of past.

i attached a patch that provides workaround for this situation.

BTW

would you please to apply a patch you proposed 
(http://sourceforge.net/tracker/?func=detail&aid=3311153&group_id=96039&atid=613414) 
to enable verbose output in melted console then it starts with -test


-- 
________________________________________
Maksym Veremeyenko