[Mlt-devel] Threshold filter inverting values

[j-b-m <j-...@us...>]

Hello!

Currently, the "threshold" effect ( vmfx/filter_mono.c) inverts black and 
white (see Kdenlive bug report for screenshot: 
http://www.kdenlive.org:80/mantis/view.php?id=234 )

The patch below fixes the issue, is it ok to commit or is there a reason for 
that inversion ?

regards
jb


Index: filter_mono.c
===================================================================
--- filter_mono.c       (revision 1182)
+++ filter_mono.c       (working copy)
@@ -44,9 +44,9 @@
                        while( size -- )
                        {
                                if ( *p >= midpoint )
+                                       *p ++ = 235;
+                               else
                                        *p ++ = 16;
-                               else
-                                       *p ++ = 235;
                                *p ++ = 128;
                        }
                }