Menu

#136 framebuffer producer ignores "in"

trunk
closed
j-b-m
5
2011-11-01
2011-10-03
No

e.g. this starts at frame 0:

melt framebuffer:/tmp/test.mov?0.5 in=30

Discussion

  • Dan Dennedy

    Dan Dennedy - 2011-10-03

    jb posted this patch to the mailing list. if you verify it, I will just merge it without testing; otherwise, I will try to look at this tomorrow evening.

    diff --git a/src/modules/kdenlive/producer_framebuffer.c b/src/modules/kdenlive/producer_framebuffer.c
    index 867a082..e60c81d 100644
    --- a/src/modules/kdenlive/producer_framebuffer.c
    +++ b/src/modules/kdenlive/producer_framebuffer.c
    @@ -52,6 +52,7 @@ static int framebuffer_get_image( mlt_frame frame, uint8_t **image, mlt_image_fo
    int freeze = mlt_properties_get_int( properties, "freeze" );
    int freeze_after = mlt_properties_get_int( properties, "freeze_after" );
    int freeze_before = mlt_properties_get_int( properties, "freeze_before" );
    + int in = mlt_properties_get_position( properties, "in" );

    // Determine the position
    mlt\_position first\_position = \(first\_frame \!= NULL\) ? mlt\_frame\_get\_position\( first\_frame \) : -1;
    

    @@ -60,7 +61,7 @@ static int framebuffer_get_image( mlt_frame frame, uint8_t **image, mlt_image_fo
    if ( !freeze || freeze_after || freeze_before )
    {
    double prod_speed = mlt_properties_get_double( properties, "_speed" );
    - double actual_position = prod_speed * (double) mlt_producer_position( producer );
    + double actual_position = in + prod_speed * (double) mlt_producer_position( producer );

        if \( mlt\_properties\_get\_int\( properties, "reverse" \) \)
            actual\_position = mlt\_producer\_get\_playtime\( producer \) - actual\_position;
    
     
  • Andrew Wason

    Andrew Wason - 2011-10-03

    I tested it and it seems to fix the problem. Thanks.

     
  • Dan Dennedy

    Dan Dennedy - 2011-10-04

    Fixed in git commit 7e1135. I will close this on the next release.

     
  • Dan Dennedy

    Dan Dennedy - 2011-11-01
    • status: open --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB