Menu

#56 Expose API for user-specified PictureData

None
closed-accepted
None
5
2020-08-26
2020-08-10
No

Picture: expose API for user-specified PictureData

This is not the nicest bit of API, as Picture isn't directly
exposed through the API, but instead ImagePlane instances
are provided through LoadFrame, and that's where the user is
most likely to want to pass through custom user data, such
as closed captions.

I am of course open to suggestions for a nicer API, but that was the
simplest patch I could think of to achieve embedding of closed
captions into the output bitstream.

1 Attachments

Discussion

  • Bernhard Praschinger

    • status: open --> closed-accepted
    • assigned_to: Bernhard Praschinger
    • Group: -->
     
  • Bernhard Praschinger

    Hallo,
    your patch is in the SVN. The original developer of mpeg2enc, has be offline for a lot of years, so the patch will be accepted the way you did.

    Regards, Bernhard

     
  • Mathieu Duponchelle

    Oh wow, awesome thanks, I did not expect anyone to review / merge this, thanks :) Unrelatedly, I have migrated the repo to git (https://gitlab.freedesktop.org/meh/mjpegtools), in case that's useful?

     
  • Bernhard Praschinger

    Sourceforge also offers git, but we did decide to migrate from CVS to SVN. You did migrate a lot of old stuff. If yout want to contribute directy to the mjoegtools SVN I can grant you write access.

     
    • Mathieu Duponchelle

      Well I didn't discriminate what stuff I migrated really, simply let git svn do its thing, for my purposes the only code I care about is in mpeg2enc/ really :) Regarding write access, I must say my familiarity with SVN is so low I'd be afraid to make a mess and never make use of it anyway, I would of course be more comfortable with a git repo but I still wouldn't be much help maintaining this project :)

       
  • Bernhard Praschinger

    No probelm, if you send patches we can integrate them.
    BTW: There are gui's for SVN and checkin of change can be done in the shell by: svn commit. ;)

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.