From: Gregg L. <gr...@li...> - 2011-01-24 15:41:25
|
On 1/22/2011 11:45 AM, Eloy Paris wrote: > A couple of notes to anyone running the "insteon" branch: this last > commit made by Gregg fixes the nightly link table scan that has been > broken for a while (don't know how long it's been broken since I just > moved to the "insteon" branch a week ago). It was supposed to happen at > 2 AM but it was failing with the following error: > > 01/22/11 02:00:00 AM Undefined subroutine: main::_get_next_linkscan > > I just tested and it is working fine now. Note that the function that > does the scan has been renamed from _get_next_linkscan() to > Insteon::scan_all_linktables(). ...which may change again before the refactoring is complete. > And related to this change in function name, when MH starts the Insteon > code adds a trigger so a full link table scan happens at 2 AM. Because > of the function name rename, you'll have to delete the previous trigger > that calls _get_next_linkscan() at 2 AM and restart MH so the new > trigger, which calls the new Insteon::scan_all_linktables() gets installed. I've added some code (not committed yet) that make any manual delete step unnecessary. > Lastly, and this is probably known by all of you running the branch and > not trunk, there is not a "Scan all link tables" voice command -- that > has been moved to the PLM menu on the Insteon category as the "scan all > link tables" menu option. Yes, and that will also likely change. So, don't get too set as to where things are. > 1. InsteonManager::is_member() and > InsteonManager::add_item_if_not_present() are also comparing objects > using "eq". They also need to be updated to use the new "equals" method, > right? Yes, changes made but not yet committed. Gregg |