[misterhouse-users] telnet.pl

[Chris B. <ch...@ba...>]

Hi,

I was looking through ./code/common/telnet.pl and noticed something strange.
The first block of quoted code is called when the connection is started and
the second when the connection is stopped.

<QUOTE>
if (active_now $telnet_server) {
    set $telnet_server 'Welcome1';
    set_echo $telnet_server 0;
#   my $client = $Socket_Ports{'server_telnet'}{client_ip_address};
    my $client = $Socket_Ports{server_telnet}{socka};
    $telnet_flags{$client}{auth} = 0;
</QUOTE>

<QUOTE>
if (inactive_now $telnet_server) {
    my $client = $Socket_Ports{'server_telnet'}{client_ip_address};
    $telnet_flags{$client}{auth} = 0;
    $telnet_flags{$client}{data} = '';
    delete $log_to_telnet_list{"$client"};
    print_log "Telnet session closed for $client";
}
</QUOTE>

In the first one, the $client is obtained via the field {socka} however in
the second it's obtained via {client_ip_address}.  In the first one $client
is set to a GLOB reference however in the second it's the IP address of the
client.  Does anyone know the reasoning behind this difference?  It would
seem from the commented out line that they used to be the same at some
stage.

Cheers,
  Chris