#231 Regression: updating from 1.1.1 to 1.1.2 breaks compatibility with Samsung D5100

[Alexandre Demers]

Regression: by updating from 1.1.1 to 1.1.2 (Archlinux 64bit), only music files are listed on a Samsung D5100 blu-ray reader, regardless if I'm under Videos, Music or Pictures menu. However, by reverting to 1.1.1, everthing is back to normal.

While trying to figure out what was wrong with 1.1.2, I tested on my Android tablet and everthing was accessible as it should. So it seems related to an identification about capabilities between my bluray reader and MiniDLNA introduced in 1.1.2.

[Alexandre Demers]

I'll bisect tomorrow and I'll give you what I'll have identified.

[Justin Maggard]

Interesting, I'm eager to see what your bisect points to. I have a D-series BDP which is able to see and play videos from 1.1.2, so maybe it's related to your configuration?

[Alexandre Demers]

First bad commit is e2c73f163d7b070145cc1a5a7853ca7431378c5f
Author: Spencer Oliver spen@spen-soft.co.uk 2013-12-05 16:42:00
Committer: Justin Maggard jmaggard10@gmail.com 2014-01-31 18:33:51
Parent: ff76966a1c955f4b56737ca11e371c5a230a817c (uuid: use CLOCK_REALTIME if CLOCK_MONOTONIC not available)
Branches: master, remotes/origin/master
Follows: v1_1_1
Precedes: v1_1_2

clients: merge samsung Series C client id

A Samsung TV cannot be reliably detected by checking for "SEC_HHP_TV"
User Agent. Only the first part can be guaranteed, eg. "SEC_HHP_" as the rest
can be changed by the end user.

Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>

[Alexandre Demers]

Maybe a log could help?

[Justin Maggard]

Yes, please, that would be great.

[Alexandre Demers]

Here is a 1.1.2 log

[Alexandre Demers]

And here a 1.1.1 log

[Spencer Oliver]

Guess this relates to FLAG_SAMSUNG_TV getting set for user agents detected as "SEC_HHP_". The previous code used the agent "SEC_HHP_TV" before it set this flag.

The issue is how do you safely detect Samsung clients that require a different root descriptor ?

[Justin Maggard]

Please try out this patch.

[Alexandre Demers]

Everything is back to normal with the patch.

[Justin Maggard]

OK, great. Spencer, any concerns? I don't have a Samsung TV to play with.

[Spencer Oliver]

On 11 Mar 2014 23:33, "Justin Maggard" jmaggard@users.sf.net wrote:

OK, great. Spencer, any concerns?

Not tested but do not see any issues.

Spen

[hal9000]

Problem still exists in version 1.1.5.
Samsung HT-C5550 home cinema can access only Music - no Videos or Photos.
Any chance for fixing this bug?

User agent for this device is:
USER-AGENT: SEC_HHP_HTS-C5500/1.0

[Shrimpkin]

There's no way of adding or modifying clients profiles without modifying the code.

If you know how to edit and compile from source, you could remove the FLAG_SAMSUNG_DCM10 from clients.c:69 (v1.1.5). Or add another client profile for your user agent.

If you have the same problem as OP, this should fix it.

[hal9000]

This is not a problem of "my user agent" but a bug introduced by Spencer Oliver in version 1.1.2.
It cannot be assumed that devices with user agent 'SEC_HHP' except 'SEC_HHP_BD' support DCM10.
Samsung home theaters with factory user agent 'SEC_HHP_HTS' doesn't support DCM10 also.
Change done by Spencer Oliver should be rolled back or user agent 'SEC_HHP_HTS' added with identical parameters as for 'SEC_HHP_BD'.
I've done it myself but not every MiniDLNA user is a programmer.
Current version of MiniDLNA has broken support for devices which worked fine before version 1.1.2 and it has to be fixed.

[Shrimpkin]

Yes, as I previously mentioned, adding another client profile will fix the issue.

The only thing that has to be done is that the source code be available to end users.

Put patches in Tickets > Patches.