From: Wu Y. <ad...@sh...> - 2005-10-13 14:28:08
Attachments:
tchar.h.diff
|
When compiling a program originally written for MSVC, I found the attached patch necessary. Apart from the addition of _TEOF <URL:http://msdn2.microsoft.com/en-us/library/z94kex77>, I also made some minor adjustments concerning the blank lines. The Change Log: 2005-10-12 Wu Yongwei <ad...@us...> * include/tchar.h: Include <wchar.h> when _UNICODE is defined. (_TEOF): New macro definition for _UNICODE and non_UNICODE cases. Please check whether it is fit. Best regards, Yongwei |
From: Dimitri Papadopoulos-O. <pap...@sh...> - 2005-10-13 15:21:59
Attachments:
tchar.h.diff
|
Hi, > Please check whether it is fit. Looks good to me, but why not add the other missing macro? _tpgmptr Dimitri Papadopoulos |
From: Wu Y. <ad...@sh...> - 2005-10-14 00:23:49
|
Dimitri Papadopoulos-Orfanos wrote: > Hi, > >> Please check whether it is fit. > > > Looks good to me, but why not add the other missing macro? > _tpgmptr > > Dimitri Papadopoulos Since we cannot copy Microsoft headers, we are adding macros on a test-and-add basis. Nothing prevents you from submitting a patch for macros you want, though, as long as you provide MSDN documentation why the patch is needed :-). Best regards, Yongwei |
From: Dimitri Papadopoulos-O. <pap...@sh...> - 2005-10-14 08:30:48
|
Hi, > Since we cannot copy Microsoft headers, we are adding macros on a > test-and-add basis. Nothing prevents you from submitting a patch for > macros you want, though, as long as you provide MSDN documentation why > the patch is needed :-). The documentation for _tpgmptr is on the very page you were referring to! I'm now doubting you've found about _TEOF in the MSDN documentation page instead of the Microsoft headers... Dimitri |
From: Wu Y. <ad...@sh...> - 2005-10-15 16:05:16
|
Dimitri Papadopoulos-Orfanos wrote: > Hi, > >> Since we cannot copy Microsoft headers, we are adding macros on a >> test-and-add basis. Nothing prevents you from submitting a patch for >> macros you want, though, as long as you provide MSDN documentation why >> the patch is needed :-). > > > The documentation for _tpgmptr is on the very page you were referring > to! I'm now doubting you've found about _TEOF in the MSDN documentation > page instead of the Microsoft headers... > > Dimitri I was talking about the standard procedure to submit a patch. The patch should be against the CVS, but not on another's patch. I did not check everything on Microsoft's page. Really I first checked it in my local MSDN documentation and then googled for an online link (and just glimpsed at it to see _TEOF was documented). I was solving my compilation problems, but not trying to implement everything in Microsoft's page into MinGW. And rechecking my local (very old) MSDN documentation shows that the page that mentions _TEOF does not mention _tpgmptr at all. Really the function did not exist in MSVC 6, and I had not known what it did (_pgmptr, _wpgmptr, and _tpgmptr) before you mentioned it. If I had diffed with Microsoft headers, I believe I could have found a lot more other stuff. Since I was just searching for a reference, and I saw _tenviron was already in the MinGW header (though crippled), I did not realize that _tpgmptr was missing at all. Best regards, Yongwei |
From: Danny S. <dan...@cl...> - 2005-10-13 20:34:17
|
----- Original Message ----- From: "Wu Yongwei" Sent: Friday, 14 October 2005 03:26 > > The Change Log: > > 2005-10-12 Wu Yongwei <ad...@us...> > > * include/tchar.h: Include <wchar.h> when _UNICODE is defined. > (_TEOF): New macro definition for _UNICODE and non_UNICODE cases. > > Please check whether it is fit. > Thanks. Checked in. Dannt |