[Ming-dev] PHP Integration

[Steve A. <al...@ne...>]

Hi list,

i've seen that Dave has back porting ming.c from PHP 4.2.2.

It is principal a good idea, but Dave has overwritten my change in this
file, and I have also back porting ming.c from 4.3.0dev.

Both version (4.2.2 and 4.3.0dev) are completely different, because in
4.3.0dev are using php streams instead of the normal file handling.

Eg.

PHP_FUNCTION(swfmovie_saveToFile)
{
        zval **x;
        SWFMovie movie = getMovie(getThis() TSRMLS_CC);
        php_stream *what;

        if (ZEND_NUM_ARGS() != 1 || zend_get_parameters_ex(1, &x) ==
FAILURE) {
                WRONG_PARAM_COUNT;
        }
        ZEND_FETCH_RESOURCE(what, php_stream *, x,
-1,"File-Handle",php_file_le_stream());
        RETURN_LONG(SWFMovie_output(movie, &phpStreamOutputMethod,
what));
}

instead of the old handling
PHP_FUNCTION(swfmovie_saveToFile)
{
  zval **x;
  SWFMovie movie = getMovie(getThis() TSRMLS_CC);
  void *what;

  if((ZEND_NUM_ARGS() != 1) || zend_get_parameters_ex(1, &x) == FAILURE)
    WRONG_PARAM_COUNT;

  ZEND_FETCH_RESOURCE(what, FILE *, x,
-1,"File-Handle",php_file_le_fopen());
  RETURN_LONG(SWFMovie_output(movie, &phpFileOutputMethod, what));
}

We should more coordinate the back porting from php tree.

I can commit every changes in php_ext/* the php cvs tree, because I have
PHP CVS access. I think we should stop the back porting and make all the
changes in the ming tree.

Maybe we could split the cvs tree in 4.2.x and 4.3.x versions.

Any suggestions?

-- 
Steve Alberty