Re: [Ming-dev] SWFShape_setLineStyle deprecated?

[Klaus R. <kl...@re...>]

Hi,

first the width value of a LineStyle structure is a 16 bit unsigned int 
value.

SWFShape_setLine() takes an unsigned short value which is multiplied by 
Ming_scale. With a scale value of 20.0 (default) the result should be 
equivalent to a pixel.

SWFShape_setLine2[filled]() creates LineStyle2 structures.

For low-level access SWFLineStyle[2] objects could be used, where the 
width value is interpreted as TWIPS. The associated SWFShape methods 
aren't in CVS yet... thats also why i deprecated

void SWFShape_setLineStyle(SWFShape shape, unsigned short width, byte r, 
byte g, byte b, byte a)

I hope this helps
    Klaus


strk schrieb:
> Just to ping out this thread.
> I happen to need subpixel accuracy for stroke thickness for Gnash testing,
> and see the issue is still open.
> SWFShape_setLine() [ the non-deprecated one ] still takes int...
> Is it expected to be Ming_setScale-sensitive ?
>
> --strk;
>
> On Mon, Jan 14, 2008 at 04:53:43AM +1100, Justin Clift wrote:
>   
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> strk wrote:
>> <snip>
>>     
>>>> As you mentioned correctly the comment / help for the above function is wrong. 
>>>> Width is used as pixel value and not as TWIPS.
>>>>
>>>> Some time ago there was a discussion how to handle this: use always pixel 
>>>> values or use always TWIPS values. Current ming is a little bit chaotic here. 
>>>>         
>>> Part of the chaos is using the ming's "scale" isn't it ?
>>> Ming_setScale() changes interpretation of all to/from user values, defaulting to 20,
>>> correct ?
>>>
>>>       
>>>> I would propose the following solution: change all values from or to users in 
>>>> TWIPS and introduce a SWF_PIXEL() macro allowing users passing pixel values.
>>>>
>>>> This change will probably break some existing user code, but it is easily 
>>>> fixable and from now on the behavior of the library is easily documentable 
>>>> and predictable by users.
>>>>
>>>> Comments ? 
>>>>         
>>> We surely want to allow specifying subpixel accuracy.
>>> What I was used to do in the past is call Ming_setScale(1) to obtain
>>> this...
>>>       
>> Ahhhh.  One of those No Clear Answer things.
>>
>> Sound like for end users either approach would work, but it would be
>> really beneficial to have One Consistent Approach all around.
>>
>> For developers, leaving it "as is" is probably most efficient. ;->
>>
>> Heh.
>>
>> For me, I don't really care at this point.  I just want us to get a
>> non-beta (i.e. Release) version out the door, even if it's not perfect,
>> as that will let distributions package it and provide it.
>>
>> I mostly use Gentoo Linux, and the most recent "stable" version for that
>> version is... 0.2a.
>>
>> (Yeah, *ugh*.)
>>
>> So, I like Klaus's idea but it sounds like it could be quite a lot of
>> change, and quite a lot of work to "get right".
>>
>> ?
>>
>> Regards and best wishes,
>>
>> Justin Clift
>>
>>     
>>> --strk;
>>>       
>> - --
>> The Flame Project - Open Source GUI for animated SVG & Flash
>> http://www.flameproject.org
>>
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v2.0.7 (GNU/Linux)
>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>>
>> iD8DBQFHilAnFAuZn5lS2IMRAulfAJ9V/I5XRHC+YPHyXQsiFS47iJkSpwCgvBtB
>> V+cYM7zmqXFkelSbbJPKt0U=
>> =QRK/
>> -----END PGP SIGNATURE-----
>>
>> -------------------------------------------------------------------------
>> Check out the new SourceForge.net Marketplace.
>> It's the best place to buy or sell services for
>> just about anything Open Source.
>> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
>> _______________________________________________
>> Ming-devr mailing list
>> Min...@li...
>> https://lists.sourceforge.net/lists/listinfo/ming-devr
>>     
>
>