#33 PLAYER.APP can't play any MMF with instruments: either simply no sound (CHORD.MMF) or freezes (MGLVNOPL.MMF)

[Ivan Ivanov]

PLAYER.APP can't play any MMF with instruments: either simply no sound (CHORD.MMF) or freezes (MGLVNOPL.MMF)

[Michal Procházka]

The MMF with instruments is played through AdLib, not the regular PC speaker. MGLVNOPL.MFF crashes on purpose

[Ivan Ivanov]

It seems your latest floppy ( at this comment - https://sourceforge.net/p/michalos/tickets/29/#a1e5/e766/106e/f016/cc01/bd29/9755/5625/1d87 ) does not contain the AdLib.APP player. This ticket #33 was only tested with PLAYER.APP at floppy from BIOS (so no AdLib hardware)

[Michal Procházka]

I don't know if I mentioned this, but I moved the ADLIB.APP code to PLAYER.APP (so it can be a single app that can play everything ;))

[Ivan Ivanov]

Is it possible to insert some detection of ADLIB hardware, so that - if it is not there - then PLAYER.APP would not try to play these files - to e.g. avoid the OS freezes caused by trying to play MGLVNOPL.MMF

[Michal Procházka]

MGLVNOPL.MMF is supposed to crash the system, it's a test dummy file, I've already removed it. Otherwise, when playing regular AdLib tunes, it shouldn't crash. I added some basic AdLib detection code, so if it doesn't detect the YM3812 (the synthesizer used in AdLib cards), it warns you about it.

https://drive.google.com/open?id=149kMflxVO0rCvz5Zp3FsnGbrcG9A-ZW4

[Ivan Ivanov]

Thank you, I just tested and this check/dialogue is working. Some possible user interface improvements:
1) In case of "YM3812 not detected" - select/highlight the Cancel button by default, so that if someone accidentally presses Enter two times on a file , he wouldn't run into a problem
2) If the user presses Cancel, return him to the file list (like you are doing if "Invalid file type!") so that he could try another file more quicker. Currently it teleports to "Choose an option" screen (one level upper)
3) Both for "Invalid file type!" and "YM3812 not detected", if the user cancels/closes the dialogue - instead of going to the first file in the list, let's stay on the same position

[Ivan Ivanov]

3+) also while navigating the menu, e.g. I press ENTER on some item then change my mind and want to choose another app so press ESC - and instead of returning to the same file in list , it always puts me to 1/ first entry

[Michal Procházka]

Thank you for your UI improvement ideas, I've done the first 2 suggestions, the third one would be very difficult to do while maintaining compatibility with the rest of the applications due to the way MikeOS dialogs work (which doesn't mean it isn't going on my TO-DO list ;))

The "highlight the Cancel button by default" already took some modification to Mike's code (but I managed to do it), and I could see some other places in the OS to implement this :)

https://drive.google.com/open?id=1wtrPcoXjHl4iiu5UXfEURajgio50lN1S

EDIT: May I consider this ticket closed, or are there any other issues regarding PLAYER.APP?

[Ivan Ivanov]

Thank you, it is better now :) Yes, please close this ticket, just remember about "3)" ;-)