Re: Implemented automatic mh-yank-cur-msg

[Mark D. B. <md...@gn...>]

Peter S Galbraith <p.g...@gl...> wrote:

> Interesting points:
> 
>  - The current method appears to be mail-citation-hook.  Indeed, it
>    appears to be its sole purpose in mh-e.
> 
>  - '(setq mh-yank-from-start-of-msg t)' is also really only useful for
>    supercite.
> 
> I propose that we leave these two things in place for backward
> compatibility (adding comments about how they used to be useful to
> invoke supercitre but are now depracated), but that we two simpler
> methods of using supercite that would hinge on a single defcustom:
> 
>  - (setq mh-yank-from-start-of-msg 'supercite)
> 
>     -> same as '(setq mh-yank-from-start-of-msg t)' concerning what text
>        gets yank, only a clearer value.  Additionally, if the user set
>        this they would not need to set `mail-citation-hook' and
>        mh-yank-cur-msg would call sc-cite-original itself if and when
>        the user yanked.
> 
>  - (setq mh-yank-from-start-of-msg 'autosupercite)
> 
>     -> same as above, but done automatically on reply.
> 
> Implementation detail: Above I said that setting
> mh-yank-from-start-of-msg could make mh-yank-cur-msg call
> sc-cite-original itself.  This is strictly correct. In the current code,
> mh-yank-cur-msg calls mh-insert-prefix-string which then calls
> mail-citation-hook.  mh-insert-prefix-string is also called by
> mh-insert-letter (so that could use supercite).  So I'd place to call to
> sc-cite-original in mh-insert-prefix-string (to be invoked if
> mh-yank-from-start-of-msg were set accordingly).
> 
> How's that?

I like it.

	-- Mark