From: Peter S G. <p.g...@gl...> - 2003-10-19 04:02:54
|
I'm CC'ing Stephen J. Turnbull and Norbert Koch because they were involved with this issue in July, and Steve Youngs because he's the XEmacs packager for MH-E. Mike Kupfer <mik...@su...> wrote: > >>>>> "Peter" == Peter S Galbraith <Peter> writes: > > Peter> I committed a small change to CVS: > > Peter> ;; Make sure `toolbar-make-button-list' is defined. See > Peter> ;; http://list-archive.xemacs.org/xemacs-beta/200307/msg00138.html > Peter> (eval-and-compile > Peter> (require 'toolbar)) > > Peter> This should fix the next release. I guess the XEmacs > Peter> people didn't patch mh-xemacs-icons.el as they sais they > Peter> would in that thread. > > I think the patch introduced a problem with their build process, so it > never made it into production. > http://list-archive.xemacs.org/xemacs-patches/200307/msg00033.html. To summarize the problem with XEmacs with the toolbar: 1- If you don't require the toolbar library, the XEmacs that byte-compiles may not be using toolbars, and thus byte-compile `(mh-funcall-if-exists toolbar-make-button-list' incorrectly, leading to an error at run-time. 2- If you do require the toolbar, then the code fails if the XEmacs binary is built without toolbar support. Questions: 1- Does using (load "toolbar" t t) instead of (require 'toolbar) work in the second case? 2- If not, do we have to unbundle toolbar-make-button-list out from mh-funcall-if-exists and replace it with some fboundp code? Peter -- Peter S. Galbraith, MH-E developer <p.g...@gl...> GPG key 1024/D2A913A1 - 97CE 866F F579 96EE 6E68 8170 35FF 799E 6623'rd GNU/Linux user at the Counter - http://counter.li.org/ |