[Mged-mage-perl] Re: MAGE-ML public identifier (was Re: [Mged-mage] Experiment -> ExperimentDesign)

[<ja...@op...>]

Jeremy Gollub <jg...@ge...> writes:

> So, can the Perl mage-ml writer be coerced to drop the SYSTEM keyword?
> Or will I have to modify my XML in a second step?

I guess it depends on how much you bribe me....

Yes. Since I failed to realize that it was invalid to have both the
PUBLIC and SYSTEM keywords present at the same time it will output
both. 

Try this patch (untested) and see if it works for you.

Cheers,
jas.
--

--- Writer.pm	(revision 504)
+++ Writer.pm	(working copy)
@@ -186,7 +186,12 @@
     $PUBLIC = '';
   }
   my $system_id = $self->system_id();
-  my $SYSTEM = qq[SYSTEM "$system_id"];
+  my $SYSTEM;
+  if (defined $public_id) {
+    $SYSTEM = qq[SYSTEM "$system_id"];
+  } else {
+    $SYSTEM = qq["$system_id"];
+  }
   my $fh = $self->fh();
   print $fh <<"MAGEML";
 <!DOCTYPE MAGE-ML $PUBLIC $SYSTEM>
@@ -624,22 +629,9 @@
       unless $empty;
 }