Menu

#54 sr_subscribe man page contains feature instructions not implemented in the code

deferred
closed-fixed
psilva
None
5
2016-11-13
2016-10-18
Eric Funk
No

the sr_subscribe man page contains the following section:

"SUNDEW COMPATIBILITY OPTIONS"

none of these options work with sr_subscribe (only with sr_sender), and thus should be removed from the man page.

Discussion

  • psilva

    psilva - 2016-11-06

    This is my fault, I misunderstood Michel when he said 'all the options from sundew are implemented' I took it to mean for the subscribers as well as the senders. While it is certainly true that the documentation is currently wrong, I'm not sure that making the documentation 'right' is the correct fix.
    This becomes a compatibility problem. If we are to 'hand off' configuration to users, we actually need this stuff to work. So the real fix is to implement the missing features.

     
  • Eric Funk

    Eric Funk - 2016-11-10

    Intersitingly it doesn't quite work all that well with sr_sender as well.

    As an example I tried the following

    filename TIME
    directory /home/sarra/senderdir/
    accept .*

    And there was a file called 'TESTFILE' which didn't get renamed with a timestamp.

    Looking in the code for sr_config

    elif spec == 'TIME':
    if destFileName != filename :
    timeSuffix = ':' + time.strftime("%Y%m%d%H%M%S", time.gmtime())
    ....

    Seems to imply that the time field only gets set if the file had been previously modified earlier. For instance if i had the following configuration:

    filename WHATFN:TIME
    directory /home/sarra/senderdir/
    accept .*

    And sent through

    TESTFILE:SOME:EXTENSION

    The extension gets removed and the timestamp gets added as expected.

    • Eric
     
  • psilva

    psilva - 2016-11-10

    those options aren't supposed to be used on their own. As the variable names imply they are suffixes... TIME all on it's own is a weird case (never used.) You are supposed to use

    WHATFN, HEADFN, or NONE

    for the initial part of the file name... so something like NONE:TIME

    is perhaps closer to what you want?

     
  • psilva

    psilva - 2016-11-11

    776b41a5513c4fac935cdc1aaedca9743464ef8b - now they are all implemented.
    try a daily-build to see.

     
  • psilva

    psilva - 2016-11-12
    • assigned_to: psilva
     
  • psilva

    psilva - 2016-11-13
    • status: open --> closed-fixed
     

Log in to post a comment.

Auth0 Logo