Re: [Mesa3d-dev] [PATCH] intel: Expose more FBconfigs in the 3D driver.

[Kristian H. <kr...@bi...>]

On Thu, Feb 5, 2009 at 4:46 PM, Peter Clifton <pc...@ca...> wrote:
> On Fri, 2009-01-30 at 11:51 -0500, Kristian Høgsberg wrote:
>> On Thu, Jan 29, 2009 at 6:08 PM, Eric Anholt <er...@an...> wrote:
>> > We can support any combination of (a8r8g8b8, x8r8g8b8, r5g6b5) x (z0,z24,z24s8)
>> > on either class of chipsets.  The only restriction is no mixing bpp when also
>> > mixing tiling.  This shouldn't be occurring currently.
>>
>> Cool, that should fix it.  Or at least let the compositing managers
>> pick the right fbconfig.  We should probably fix all drivers to report
>> RGB visuals, and then we can yank the reset-alpha-channel hack in the
>> tfp sw fallback.
>
> It doesn't fix it on its own.. certainly not for the intel driver.
>
> The setTexBuffer hook still explicitly sets the format of the texture to
> be BGRA, and I assume it ought to be setting this information based on
> the FBconfig (now hopefully correct) of the GLXPixmap the texture is
> being mapped from.
>
> Does anyone have any hints how start fixing that?

Something like the attached patch?  Haven't tested it...

cheers,
Kristian