Re: [Mesa3d-dev] drixorg: software renderer with dri_interface.h

[George - <fuf...@ho...>]

> Date: Mon, 12 May 2008 12:25:26 -0400
> From: kr...@bi...
> To: fuf...@ho...
> Subject: Re: [Mesa3d-dev] drixorg: software renderer with dri_interface.h
> CC: mes...@li...
> 
> Wow, that's awesome work.  My initial plan was to just wrap a dri
> interface around the XMesa driver, but this is much better. You drop
> the XMesa middle man and use the mesa internal API directly, which
> avoids hooking into the X server internals from XMesa.  This also
> makes it much easier to load the sw dri driver from libGL.  A few
> comments on the patches:
> 
> 1. Can we call it swdri instead of drixorg? There's nothing xorg
> specific about it and the hw dri drivers also work with xorg.  In
> fact, this makes it easy to load the sw driver from a non-X loader
> (say, EGL).
> 

that is:
drivers/dri/xorg -> drivers/dri/sw
xorg_dri.so -> sw_dri.so
glxdrixorg.c -> glxdrisw.c

right ?

otherwise, we'll either have dri twice in the name (swdri_dri.so) or sw dri
will not follow the hw dri naming conventions (swdri.so).

I'll repost the patches and use the suggested names right from the beginning.

> 2. Create the __DRIconfigs in the drixorg driver and share the
> __DRIconfig conversion code in glxdri2.c in the xserver (and libGL).
> That's what the hw drivers do, because they know exactly what
> fbconfigs they can support.  That's also true for the sw dri driver.
> 
> 3. Just add a __DRISWExtension, along the lines of
> __DRIlegacyExtension instead of reusing the
> createScreen/createDrawable and createContext entry points from
> __DRIcoreExtension.  This lets you pass in exactly the parameters
> required, and only those (instead of ignoring the unused fd and sarea
> handle).
> 
> 4. Add a resizeDrawable entry point to the __DRISWExtension interface
> to be called when __glXDRIdrawableResize is called from the glx
> module.  Not sure how to handle this when you load the sw dri driver
> on the client side, but you probably don't want to do that anyway...
> 

ok! will do after reposting the patches, unless someone wants to help :-)

> 5. Add yourself as copyright holder on the files you've authored :)
> 
will do this in the reposted patches.

Thanks for your thorough review and dri2 work!
George.


_________________________________________________________________
Discover the new Windows Vista
http://search.msn.com/results.aspx?q=windows+vista&mkt=en-US&form=QBRE