Re: [Mesa3d-dev] mesa: Changes to 'master'

[Keith W. <ke...@tu...>]

Nan hai Zou wrote:
>  src/mesa/drivers/dri/i965/brw_clip_line.c  |    7 +
>  src/mesa/drivers/dri/i965/brw_clip_state.c |    2 
>  src/mesa/drivers/dri/i965/brw_clip_tri.c   |  105 ++++++++++++++++++++++++++++-
>  src/mesa/drivers/dri/i965/brw_clip_util.c  |   12 ---
>  4 files changed, 112 insertions(+), 14 deletions(-)
> 
> commit diffs at http://gitweb.freedesktop.org/?p=mesa/mesa.git;a=summary
> 
> New commits:
> commit b47c9f8c915ae4ca8c7fa5ee3b6b64f17c38b569
> Author: Zou Nan hai <nan...@in...>
> Date:   Fri Aug 31 13:42:20 2007 +0800
> 
>       optimize 965 clip
>       1. increase clip thread number to 2
>       2. do cliptest for -rhw

Nan hai Zou,

Isn't it the case that the hardware bug that requires the -rhw 
workaround is fixed in later versions of the hardware?  It would be good 
to turn the workaround off in those cases - both in the clipper and the 
vertex shader.

Likewise, the various workarounds for send destination dependency 
checking (eg. in brw_vs_emit.c emit_math1(), etc.) can be turned off in 
later revisions and steppings of the hardware.  This is probably quite 
important as I believe the workaround defeats built in latency-hiding 
characteristics of the hardware.

It's also worth noting that the hardware support for guard band clipping 
isn't turned on in the current i965 driver.  Making use of this could 
give a good boost to clipping performance...

Otherwise, looking good.  It's nice to see the driver continuing to evolve.

Keith