From: Oliver M. <z3r...@gm...> - 2007-03-15 19:56:03
|
I committed the _mesa_alloc_instructions/_mesa_init_instructions changes. Please let me know if I've broken anything here. I believe it's perfectly fine, though. insert_wpos in r300_vertexprog.c could use some improvement though. I'm not sure if it's best to memcpy the END instruction too, or explicitly specify it, eg: vpi[i].Opcode = OPCODE_END; Btw, would anyone have a problem renaming r300_vertexprog.c to r300_vertprog.c; this is the name everyone else uses and it's shorter, too. :) On 3/15/07, Rune Petersen <ru...@me...> wrote: > Brian Paul wrote: > > Some code comments below: > > > > *comments* > > Thank you, I find comments like these very helpful. > > > Rune Petersen > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys-and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Mesa3d-dev mailing list > Mes...@li... > https://lists.sourceforge.net/lists/listinfo/mesa3d-dev > |