[Mesa3d-dev] [Bug 3899] minor src/glx/x11 cleanups

[<bug...@fr...>]

Please do not reply to this email: if you want to comment on the bug, go to    
       
the URL shown below and enter yourcomments there.     
   
https://bugs.freedesktop.org/show_bug.cgi?id=3899          
     

id...@us... changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|mesa3d-                     |id...@us...
                   |de...@li...   |




------- Additional Comments From id...@us...  2005-07-29 03:44 -------
(In reply to comment #0)
> In the spirit of cleaning libGL code, here are some minor suggestions:
> 
> *	src/mesa/drivers/dri/common/glcontextmodes.c
> 
> 	__DRIinterfaceMethodsRec provides both createContextModes and 
> 	destroyContextModes. The dri drivers use createContextModes from 
> 	__DRIinterfaceMethodsRec and _gl_context_modes_destroy directly 
> 	from glcontextmodes.c (called within dri_util.c). Is this on purpose ? 
> 	Otherwise, the dri drivers could use destroyContextModes instead of 
> 	_gl_context_modes_destroy. In that case, it is possible to:
> 
> 	o	move glcontextmodes.[hc] to src/glx/x11/
> 	o	eliminate IN_DRI_DRIVER from glcontextmodes.[hc]

That should be doable.  Having glcontextmodes.c compiled into the DRI drivers is
an artifact of having to support versions of libGL that didn't supply it.  Since
we no longer need to support those versions, it can go.

> 	Moreover, 
> 
> 	o	functions _gl_convert_to_x_visual_type and 
> 		_gl_copy_visual_to_context_mode appear to be dead code
> 	o	the #ifdef XFree86Server directive appears to be dead code 
> 		since the symlink-mesa.sh script from xorg does not symlink 
> 		glcontextmodes.c

Where does it get glcontextmodes.c?  I set it up like that so that we wouldn't
have to keep two copies of the file in sync.

> *	src/glx/x11/glxclient.h
> 
> 	remove structs marked as DEPRECATED

Yes!  Those can finally go away!  They had to be left in place because changing,
moving, or removing them broke binary compatibility with older DRI drivers.  A
few of the changes in the "new" interface were designed specifically to fix
this.  We should be able to gut these at any point with no problems.

> *	include/GL/internal/dri_interface.h
> 
> 	DRI_NEW_INTERFACE_ONLY "survived" as "#if 0", better remove it

Oops.  I changed it to '#if 0' to make sure it really could be removed, but
never went back and removed it.

> *	src/glx/x11/Makefile
> 
> 	see patch below (tested with glxgears), under the assumptions that:
> 
> 	o	glcontextmodes.[hc] was treated as above
> 	o	dispatch.c can be compiled similar to glapi.c, not symlinked
> 	o	the code in src/mesa/main/glheader.h within 
> 		the #ifndef __MINGW32__ directive is actually 
> 		moved somewhere in src/mesa/drivers/windows/

I think that should be doable.  I'll have to look at it a bit more.

FYI, in-line patches are pure evil. :)
          
     
     
--           
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email         
     
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.