Re: [Mesa3d-dev] r200 6 tmu patch updated again

[Keith W. <ke...@tu...>]

Roland Scheidegger wrote:
> Keith Whitwell wrote:
> 
>>>>> Oh, and I've left out the changes to r200_maos_verts.c and 
>>>>> r200_maos_vbtmp.h, is there any point in updating these? I'd rather 
>>>>> remove them.
>>>>
>>>>
>>>> Last time I checked, they were the faster path...  They have some 
>>>> bugs though.
>>>
>>>
>>>
>>> Is this the reason they are not enabled (though they are for radeon)? 
>>> Guess they need to stay if they are faster - though if they are never 
>>> used they don't help much neither...
>>
>>
>>
>> It's been a long time, but I do definitely remember hardware seemed to 
>> process vertices quicker than it got through arrays.  It really needs 
>> to be reexamined, though.
>>
> Just wanted to examine that with some benchmarks, unfortunately it won't 
> compile. Some import files are missing, and even if they were not it 
> looks like it wouldn't compile... Looks like the radeon version of it 
> got some updates which the r200 version is missing.

If it's that rotten, it can go.  Maybe leave a note saying that it was 
suspected to be the better perf path.

One reason it got replaced was that the vertex started getting a lot more 
elements in it and the old dd_vbtmp.h file couldn't cope.  The new t_vertex.c 
path fixes that, but it itself needs a bit of work on performance...

Let's just cut the crap & ditch the dead code.

Keith