#516 fix(ci): unset notarization creds for staging instead of blanking them

[Anonymous]

Originally created by: adityaharishch

v1.72.0-staging.7 failed at the bundle step:

failed to notarize app: Error: The value '' is invalid for '--issuer <issuer>':
must be a valid UUID

Cause

My staging notarization skip in [#514] gated the job env with:

APPLE_API_ISSUER: ${{ needs.prepare.outputs.channel == 'stable' && secrets.APPLE_API_ISSUER || '' }}

An Actions expression that yields '' still defines the variable as an empty string. Tauri decides whether to notarize by checking whether the credentials are present, and defined-but-empty reads as present - so it ran notarytool --issuer ''.

APPLE_API_KEY_PATH made it unavoidable anyway: .github/actions/import-apple-cert writes the .p8 and exports its path via GITHUB_ENV unconditionally, so it is present no matter what the job env: says.

Fix

Set the credentials unconditionally, and unset APPLE_API_KEY APPLE_API_ISSUER APPLE_API_KEY_PATH inside the bundle step on non-stable channels. That is the only gate that removes them from the environment tauri actually inherits.

Signing is untouched on every channel - APPLE_SIGNING_IDENTITY and the keychain stay, so staging is still Developer ID signed (which is what the updater's relaunch depends on). Stable still fully notarizes.

Note

v1.72.0-staging.8 was cut from the [#515] merge and carried the same bug, so I cancelled it mid-compile rather than let it burn ~15 more minutes to reach the same failure.

[Anonymous]

Originally posted by: coderabbitai[bot]

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5740c908-9032-492e-b8ec-39494ef71154

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:
- [ ] 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

- [ ] Create PR with unit tests - [ ] Commit unit tests in branch `fix/staging-notarize-skip`

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

_{Comment @coderabbitai help to get the list of available commands.}

[Anonymous]

Ticket changed by: adityaharishch

• status: open --> closed