#409 feat(coding-agents): widen get_coding_agents to all 4 ingested tools

[Anonymous]

Originally created by: adityaharishch

Summary

• CODING_AGENTS only listed Claude Code and Codex, silently dropping GitHub Copilot and Cursor Agent sessions from get_coding_agents
• Widens to all 4 ingested tools per CLAUDE.md's coding-agent pipeline table; Antigravity stays excluded (detection-only, never ingests)

Stacked on #(fix/dev-start-orphan-cleanup) — diff will shrink to just this commit once that merges.

Test plan

• [x] cargo build -p meridian-core

[Anonymous]

Originally posted by: coderabbitai[bot]

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2a734c92-75a8-4c0a-bd74-80f1eb18a9f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:
- [ ] 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

- [ ] Create PR with unit tests - [ ] Commit unit tests in branch `feat/coding-agents-more-providers`

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

_{Comment @coderabbitai help to get the list of available commands.}

[Anonymous]

Originally posted by: Akarsh-Hegde

Review — widen get_coding_agents to all 4 ingested tools

Summary: A correct, minimal widening — the two edited constants match the ingest table exactly and stay consistent with each other; the only real gap is missing test coverage for the two newly-included agents.

Blocking / correctness issues

None. Cross-checking the four app_name values against CLAUDE.md's "Ingested agents" table:

• Claude Code, Codex, GitHub Copilot (CLI + VS Code chat share it), Cursor Agent (Cursor IDE + cursor-agent CLI share it) — all match what the ingest pipeline actually writes. Antigravity correctly excluded (detection-only).
• The SQL IN (...) list (coding_agents.rs:81) and the CODING_AGENTS array (coding_agents.rs:34) list the identical four names, so total_s and the per-agent breakdown can't disagree. File header, #[tracing::instrument], span, and info! summary all intact.

Suggestions / nits

• Missing test coverage for the new agents (main actionable item). meridian-core/tests/readers.rs:83 (coding_agents_unions_overlap_per_agent_and_total) still only seeds Claude Code + Codex and asserts agents.len() == 2. Per the port playbook, add a GitHub Copilot and a Cursor Agent row so the test exercises exactly the behavior this PR adds — it would guard against the regression being fixed (agents silently dropped) and against future SQL/const drift. As written, cargo test still passes even if one of the two new names were fat-fingered in only one of the two locations.
• Duplicated agent list, two sources of truth (:34 const vs :81 inline SQL). They agree today, but a future one-sided edit would split total-vs-per-agent silently. sqlx can't bind an array cleanly, so the hardcoded IN is defensible — but a comment tying the two together, or building the IN placeholders from CODING_AGENTS.len() and binding the slice, would remove the trap.
• Doc framing nit: the module header still opens with "a faithful port … byte-identical" (:2-9), but the agent set is now a deliberate divergence from the original route's two-element list. A one-line note in the CODING_AGENTS doc-comment would keep the header honest.

Verdict: Approve once a test seeding a GitHub Copilot and a Cursor Agent row is added — the production change itself is correct and ready.

_{🤖 Automated review via Claude Code}

[Anonymous]

Ticket changed by: adityaharishch

• status: open --> closed