#408 fix(dev): kill orphaned next dev + legacy a11y-helper on dev-start

[Anonymous]

Originally created by: adityaharishch

Summary

• next dev (spawned as a child of tauri dev via beforeDevCommand) can be orphaned by rapid dev-start restarts, holding port 3939 and breaking the next run
• Also stops the legacy launchd com.meridiona.a11y-helper if still installed, since capture now runs in-process in the dev tray binary and a lingering helper would double-write capture tables

Test plan

• [x] Manual: re-ran dev-start.sh after a rapid restart, confirmed no orphaned next dev on 3939

[Anonymous]

Originally posted by: coderabbitai[bot]

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ae5a3c1c-d309-4691-9570-6373759f03ce

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:
- [ ] 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

- [ ] Create PR with unit tests - [ ] Commit unit tests in branch `fix/dev-start-orphan-cleanup`

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

_{Comment @coderabbitai help to get the list of available commands.}

[Anonymous]

Originally posted by: Akarsh-Hegde

Review — kill orphaned next dev + legacy a11y-helper on dev-start

Summary: The dev-start.sh change is correct and safe, but the PR bundles in two unrelated timeline-UI files that don't match its stated intent.

Blocking / correctness issues

None. The shell changes are sound:

• dev-start.sh:75 — pkill -f 'next dev --turbopack -p 3939' matches the exact ui/package.json dev script and is scoped tightly by the port, so it won't touch unrelated next dev instances.
• dev-start.sh:84-88 — the a11y-helper launchctl print → disable → bootout block byte-for-byte mirrors the existing com.meridiona.daemon block above it, and com.meridiona.a11y-helper is the real legacy label (confirmed in install-dev.sh:9, CONTRIBUTING.md:57). Preventing a lingering helper from double-writing the capture tables is a legitimate, well-justified fix.

Suggestions / nits

• Scope creep (please address): ui/components/timeline/ActivityReport.tsx and ui/components/timeline/TimelineColumn.tsx are a timeline TLDR-preview feature (extractTldr, TldrPreview, swapping the full report for a clamped TLDR card) with zero connection to "kill orphaned next dev + legacy a11y-helper." The PR title, body, and test plan only cover dev-start. Recommend splitting these into their own PR (this looks like it overlaps with [#406]) — or at minimum update the title/body to disclose the UI change. The UI code itself looks fine.
• Brittleness nit (dev-start.sh:75): the pattern hard-codes --turbopack -p 3939, duplicating ui/package.json. If the port/flags change there, this silently stops matching and orphans return with no error. A looser next dev.*3939 would survive a flag tweak. Optional.

Verdict: Approve the dev-start.sh portion as-is — a clean, correct fix. Request that the two ui/components/timeline/* files be split out (or the PR title/body updated to disclose them) before merge.

_{🤖 Automated review via Claude Code}

[Anonymous]

Ticket changed by: adityaharishch

• status: open --> closed