Originally created by: Akarsh-Hegde
Four groups of dead references from earlier retirements are excised in one pass. All dead references go away. One deliberate behavior change: removing cleanup_legacy_ui / retire_legacy_ui_server drops the one-time purge of a leftover pre-Next-fold com.meridiona.ui launchd agent — a passive zombie (dev-only port, no clash), acceptable for the current actively-updating pilot base. The active-conflict purges (screenpipe, mlx-server) are kept.
scripts/meridian-cli.sh — drop LABEL_UI, the doctor's ui plist row, and _dev_stop_prod_uiscripts/install-from-bundle.sh — drop retire_legacy_ui_server fn + call sitetray/src-tauri/src/backend_install.rs — drop cleanup_legacy_ui fn + call sitetests/install/test_plist_lint.sh + tests/install/test_plist_render.sh — strip the ui-plist blocks (files stay; they still cover daemon + screenpipe plists)src/health/{ui,platform}.rs — retouch docstrings that named com.meridiona.uiui.tar.gz entry from npm/meridian-darwin-arm64/package.json files[] — bundle hasn't shipped it since the tray-embed cutover.src/config.rs — drop screenpipe_db field, env parse, default, tracing site, struct init, and the screenpipe_db_uri() methodscripts/com.meridiona.daemon.plist — drop <key>SCREENPIPE_DB</key> entry.env.example — drop the commented lineTESTING.md §3 — rewrite from "screenpipe DB compatibility" to "capture DB compatibility" (empty capture + WAL)tray/src-tauri/src/commands/setup.rs — retouch the docstring line referencing the old proxy checkIntentionally left alone. What looked like cleanup candidates are all load-bearing:
src/coding_agent_session_ingest/db.rs's CATEGORY_METHOD = "coding_agent_indexer" is the DB row provenance label — data continuity.services/scripts/install-claude-hook.sh's OUR_MARKERS tuple + scripts/uninstall-daemon.sh's legacy boot-out loop are functional upgrade cleanups that still purge pre-port installs.cargo check --workspace cleancargo clippy --workspace -- -D warnings cleancargo test -p meridian --lib config:: — 17 config tests passbash tests/install/test_plist_lint.sh — daemon + screenpipe plists lintbash tests/install/test_plist_render.sh — daemon + screenpipe plists render + lint🤖 Generated with Claude Code
Originally posted by: coderabbitai[bot]
✨ Finishing Touches
🧪 Generate unit tests (beta)
- [ ] Create PR with unit tests - [ ] Commit unit tests in branch `chore/remove-retired-artifacts`Comment
@coderabbitai helpto get the list of available commands.Originally posted by: adityaharishch
Reviewed the diff and cross-checked the PR branch (
chore/remove-retired-artifacts, commit 818311b0) for dangling references to everything it deletes. Overall this is clean, well-scoped dead-code removal — one real doc-staleness issue and one low-severity behavioral note.Findings
🟡 CLAUDE.md is now stale (not touched by this diff): the Environment Variables table still has a row for
SCREENPIPE_DBthat says "Vestigial after the Bucket-2 cutover... Still parsed intoConfigwith a default; slated for removal" (CLAUDE.md:205). After this PR,screenpipe_dbis fully removed fromConfig(src/config.rs) — the row is now factually wrong (nothing parses it anymore) and should either be dropped or reworded to reflect that removal already happened. Since CLAUDE.md is loaded as binding instructions for every future agent/session on this repo, leaving it inaccurate will actively mislead future work. (The othercom.meridiona.uimention at CLAUDE.md:131-132 is fine — it's already phrased in the past tense describing the earlier Next-fold retirement, not affected by this PR.)🟢 Low-severity:
cleanup_legacy_uiremoval frombackend_install.rs/install-from-bundle.shdrops the one-time zombie-agent purge for pre-Next-fold bundle installs, while the siblingcleanup_legacy_screenpipe/cleanup_legacy_mlx_serverpurges are kept. If any install has been fully dormant (no updates) since before the Next-fold and jumps straight to a post-#399 build, it will no longer get its leftovercom.meridiona.uilaunchd agent booted out — a minor zombie-process risk rather than a functional break. Given the Next-fold long since shipped and the small/actively-updating pilot user base, this is probably an acceptable one-time cleanup to finally retire, just flagging for awareness since the PR body's "all live behavior preserved" claim doesn't quite cover this edge case.Verified clean (no dangling references found)
com.meridiona.ui.plistitself was already deleted in an earlier commit (03323996) — this PR actually fixes a pre-existing dangling reference intests/install/test_plist_lint.sh/test_plist_render.sh, which referenced a plist file that no longer existed onpre-mainbefore this PR. Nice catch.LABEL_UI,retire_legacy_ui_server,cleanup_legacy_ui,_dev_stop_prod_ui,SCREENPIPE_DB,screenpipe_db/screenpipe_db_uri, andui.tar.gz— all remaining hits are either historical/changelog prose or comments explicitly documenting that the artifact is no longer shipped (scripts/meridian-npm-setup.sh,scripts/package-release.sh,scripts/verify-release-bundle.sh), not functional dependencies.scripts/uninstall-daemon.shhas no UI-agent references to clean up.src/etl/text_filter/tests.rs:134sample log string"...config loaded screenpipe_db=..."is just fixture text for a noise-filter regex test, unrelated to the actualtracing::info!output — harmless, not worth changing.Assessment: Solid, well-verified cleanup PR. Fix the CLAUDE.md
SCREENPIPE_DBtable row before/after merging; the zombie-agent note is optional context, not a blocker.Originally posted by: Akarsh-Hegde
Thanks — both points addressed.
🟡 Stale CLAUDE.md
SCREENPIPE_DBrow (fixed in 52f01ba7)Dropped the env-var table row entirely (the var +
Config::screenpipe_dbfield are gone, so it's not "slated for removal" — it's removed), and reworded the capture-source note at the bottom of the Capture section from "SCREENPIPE_DBis now vestigial" to "theSCREENPIPE_DBenv var +Config::screenpipe_dbfield have been removed." Good catch — CLAUDE.md being wrong would actively mislead future sessions.🟢
cleanup_legacy_ui/retire_legacy_ui_serverremoval (zombie-agent purge)You're right that this isn't strictly "all live behavior preserved" — I'll correct that overclaim in the PR body. The reasoning for going ahead with the removal:
cleanup_legacy_screenpipe/cleanup_legacy_mlx_serverpurges are kept because those agents contend for a live resource (Screen Recording prompt, port 7823) — an active conflict. Thecom.meridiona.uiagent is a passive zombie (its port 3939 is dev-only, no clash), so a leftover is wasted RAM, not a functional break.If you'd rather keep the one-time purge as belt-and-suspenders, I'm happy to restore just those two functions (they're cheap and self-limiting) and keep the rest of the dead-reference removal — your call. Otherwise I'll leave them retired and fix the PR-body wording.
Ticket changed by: Akarsh-Hegde