Menu

#339 feat(ui): dashboard full-screen with dock + MLX server startup fix

closed
nobody
None
2026-06-25
2026-06-25
Anonymous
No

Originally created by: Akarsh-Hegde

Summary

  • Dashboard full-screen with dock integration — opens full-screen on launch with a dock icon; adds "Go to Setup" button wiring
  • Activation policy fix — reverts activation policy on dashboard close + adds tracing on open_setup
  • MLX server startup fix — adds missing instrument_agno() to observability.py (server was crashing on startup with AttributeError since the cleanup commit 155b26c added the call without writing the function)
  • Security — sanitises agent_name before using it as a log filename in _configure_logging to prevent path traversal

Test plan

  • [ ] Open Meridian → dashboard opens full-screen with dock icon visible
  • [ ] "Go to Setup" button navigates to the setup window
  • [ ] Close dashboard → tray still visible, activation policy restored correctly
  • [ ] Start MLX server via dev-start.sh — no AttributeError on startup, server reaches Waiting for application startup cleanly
  • [ ] meridian doctor shows no capture or daemon faults

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
  • Added optional agent instrumentation support for improved telemetry when the required package is installed.

  • Bug Fixes

  • Improved log file naming by safely sanitizing agent names, reducing the risk of invalid or unsafe filenames.

Related

Tickets: #347

Discussion

  • Anonymous

    Anonymous - 2026-06-25

    Originally posted by: coderabbitai[bot]

    [!IMPORTANT]

    Review skipped

    Auto reviews are disabled on base/target branches other than the default branch.

    Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.


    ⚙️ Run configuration

    Configuration used: Organization UI

    Review profile: ASSERTIVE

    Plan: Pro Plus

    Run ID: 7fe03169-6be2-4296-8a2c-b7ee3ea3b8a7

    You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

    Use the checkbox below for a quick retry:
    - [ ] 🔍 Trigger review

    ✨ Finishing Touches
    🧪 Generate unit tests (beta) - [ ] Create PR with unit tests - [ ] Commit unit tests in branch `feat/dashboard-fullscreen-dock`

    Comment @coderabbitai help to get the list of available commands.

     
  • Anonymous

    Anonymous - 2026-06-25

    Originally posted by: Akarsh-Hegde

    Addressed both CodeRabbit findings in f652739:

    Comment 1 — structured telemetry in instrument_agno warning path

    • Replaced the plain-string warning() with a structured call using extra={"package": …, "reason": …, "fix": …} so the dependency failure is machine-readable in OpenObserve
    • When a span is active at call time (span.is_recording()), marks it ERROR with a descriptive message

    Comment 2 — empty safe_name fallback

    • Added if not safe_name: safe_name = "agent" after the sanitization loop, so an all-symbol agent_name produces agent.jsonl instead of a bare .jsonl
     
  • Anonymous

    Anonymous - 2026-06-25

    Ticket changed by: Akarsh-Hegde

    • status: open --> closed
     

Log in to post a comment.