Originally created by: Akarsh-Hegde
Summary
- Dashboard full-screen with dock integration — opens full-screen on launch with a dock icon; adds "Go to Setup" button wiring
- Activation policy fix — reverts activation policy on dashboard close + adds tracing on
open_setup
- MLX server startup fix — adds missing
instrument_agno() to observability.py (server was crashing on startup with AttributeError since the cleanup commit 155b26c added the call without writing the function)
- Security — sanitises
agent_name before using it as a log filename in _configure_logging to prevent path traversal
Test plan
- [ ] Open Meridian → dashboard opens full-screen with dock icon visible
- [ ] "Go to Setup" button navigates to the setup window
- [ ] Close dashboard → tray still visible, activation policy restored correctly
- [ ] Start MLX server via
dev-start.sh — no AttributeError on startup, server reaches Waiting for application startup cleanly
- [ ]
meridian doctor shows no capture or daemon faults
🤖 Generated with Claude Code
Summary by CodeRabbit
Originally posted by: coderabbitai[bot]
✨ Finishing Touches
🧪 Generate unit tests (beta)
- [ ] Create PR with unit tests - [ ] Commit unit tests in branch `feat/dashboard-fullscreen-dock`Comment
@coderabbitai helpto get the list of available commands.Originally posted by: Akarsh-Hegde
Addressed both CodeRabbit findings in f652739:
Comment 1 — structured telemetry in
instrument_agnowarning pathwarning()with a structured call usingextra={"package": …, "reason": …, "fix": …}so the dependency failure is machine-readable in OpenObservespan.is_recording()), marks itERRORwith a descriptive messageComment 2 — empty
safe_namefallbackif not safe_name: safe_name = "agent"after the sanitization loop, so an all-symbolagent_nameproducesagent.jsonlinstead of a bare.jsonlTicket changed by: Akarsh-Hegde