Menu
▾
▴
#801 Repair tasks automatically fails if the unit is set to salvage mode after the task is started and the day is advanced
For example let's say you schedule a repair task to replace an arm. You switch the mech to salvage mode and advance the day. The repair task will automatically fail as the odds have been changed to "Impossible". It shouldn't be changing to impossible.
See the daily log of : https://sourceforge.net/p/mekhq/bugs/799/attachment/3025.rar
Same thing occurs if the mech is automatically deployed the next day due to a pending battle. All repair tasks automatically fail even if the mech remains in repair mode.
Well, there are really 2 bugs here. I would appreciate if you would report the 2nd as a separate AtB bug please. The bug is that mechs that are under repair shouldn't be able to be deployed by the auto-deploy AtB code.
As for the first issue... you shouldn't be changing between the two modes mid-task, but yes, it also shouldn't dump if you do.
Actually switching between the two modes is pretty common because you often need to salvage stuff off of destroyed limbs before you can replace them. So you might be switching between that and repairing other parts of the unit.
In any case, I actually corrected this issue in (0.3.16) when I removed the salvage dummy on the part item. Part now tracks whether the part is being salvaged or not if and only if is has an assigned team for overnight repairs. This allows for it to correctly do the right thing when they spend their allotted time in the next day regardless of the repair/salvaged status of the unit. It is important to note that you can still get an Impossible if you do other things to the unit that would make the task impossible, the most likely being replacing equipment on a location that you are trying to salvage. That is woking as it should, though. I suppose we should probably put in a check on this to see if there is an overnight task to salvage a location and then make fixing parts on that location impossible, but this situation is rare enough that I think I will let it go unless we see user confusion.
So closed for out-of-date.