#4632 Initiative Problems

[Alex]

0.41.9

I assume this is due to "Infantry don't count for initiative" as was previously the case... I was also using lance movement for tanks and mechs.

I had a recent game where after a few hovercraft skidded, I was forced to move an additional platoon of them. I also received the old "Player has no units to move" issue. As a result, at the end of the round - despite winning initiative - the other player was the last to move his ground forces.

Nothing apeared in the log.

[Alex]

Adding the game options per request.

[Nicholas Walczak]

Fixed in [c4e861].

This is related to [#4271]. Basically, my fix was not quite right for that bug. The issue is that, when skids/falls/etc happen during movement, a new SpecificEntityTurn is added to the turn vector. Then, after Server.processMovement, Server.endMyTurn is called (in Server.receiveMovement). endMyTurn will add more turns for the move-multi rules.

In my previous fix, I made the new SpecificEntityTurn inherit the isMultiTurn state from the current turn. Actually, it should always be true. The multi-turns will get added when the turn that caused the new SpecificEntityTurn ends, so if the SpecificEntityTurn has the false isMultiTurn state of that current turn, you'll get too many turns. I missed this before because the bug only happens if the first unit in a lance skids/falls.