#4135 Warning Message for no Firing Declaration

[Ryo]

ver: 0.37.11-exp

MegaMek show a warning message like "This unit has not fired any weaoins. Are you really done?" when the unit does not fire at all and the controlling player push "Done" button.

But when the mech twisted its torso and did not fire at all, the warning message does not appear. The mech has not fired any weapons and the message should be shown.

It would be kind fail safe to ignore twisting status for checking whether units has fired or not.

Thanks.

[Klaus Mittag]

Right. The problem is that torso twists and arm flips and a number of other not-strictly-attack actions like spotting all get written into the same "attacks" collection as the actual attacks and the nag screen will only pop up if that one is completely empty.

This could be a bit of a design call. The "simple" fix would be to make that test more sophisticated than just "has the player already done anything at all or not?"; on the other hand, explicitly separating the actual attacks from the "miscellaneous" actions on a basic level rather than just lumping them all into the same Vector might be the cleaner solution in the long run, though it'd probably mean more work.

[Nicholas Walczak]

There's also a question about the intent of the feature. I think it's really there to keep you from accidentally hitting done when you haven't actually done anything. Like, your turn comes up and you click to get focus, whoops you accidentally clicked the done button! If you've torso twisted, you've actually been doing something and I feel like it's less likely that you will accidentally click done.

I think it would be nice but not worth fixing. We also have to consider what other non-attack actions would count. If I've fired my spotlight but no weapons, should I get nagged? What about spotting with no weapons fire?

We could always change the report too, to something like, "This unit hasn't taken any actions. Are you really done?"

[Nicholas Walczak]

I updated the messages in [r10901]. It now says, "This unit has not taken any actions." I think this is as far as we should go; I'm going to close the ticket.

[Ryo]

I agree with you, and the function would not worth fixing. Thank you for changing the message! Please close this ticket.