Menu
▾
▴
#4110 Allowed Units & Equipment Option: ver. 0.37.11-dev (MHQ 0.3.5)
1) When "Canon Units Only" is checked and do "Add A Combat Unit," no units appear on "Select Mech" panel.
2) "Ammo & Equipment Limits" may be based on the game year, but Introductory mech cannot mount any other ammo types other than standard ammo.
For example, Shadow Hawk SHD-2H and Dragon DRG-1N are IS Introductory Box Set units. If "Ammo & Equipment Limits" options is checked, I cannot select any other ammo types other than standard ammo on Equipment tab of Configure panel.
Thanks.
In the future, please keep separate issues in separate tickets.
I've fixed the "Canon Units Only" issue. The file is stored in the docs directory, but the MechFileParser was looking for it in the data/mechfiles directory, so it wasn't finding the file.
As a bonus, I noticed that loading units was slower after making the fix. I looked into it, and when setting the isCanon flag for Entity's when they are loaded, a linear search is performed on the canonunitlist. We have ~7k units and ~5.5k canon units, so this ends up being slow. I sorted the collection and used a binary search instead. This should speed things up.
As for the second one, this is operating as intended.
If you pick a unit that has a tech level of "IS Intro Boxed Set" and you set the "Ammo & Equipment Limits" option, you are saying that the unit can only use ammo that matches its tech level (ie, IS Intro Boxed Set). The only ammos, regardless of game year, that are IS Intro Boxed Set are the "standard" ones.
So, take Clan Artemis V ammo for instance. Prior to 3085, it's Clan Experimental tech but in 3085 it becomes Clan Advanced tech. If you've got a Clan Advanced unit and the ammo limit option turned on, the unit can't use Clan Artemis V ammo unless the game year is 3085 or later.
Prior to the recent fix, instead of using the game year, it would use the Entity's construction year.
The problem with "Ammo & Equipment Limits" is that it's based on the construction rules level of the unit as found in its data file, not whichever rules level the game is nominally supposed to play out under (which currently isn't actually something that can be straightforwardly set). So if I have that option on, it doesn't matter that the battlefield is full of optional-rules stuff like minefields and artillery and tripod superheavy 'Mechs fielding experimental Clan gear -- that old level 1 SRM Carrier trundling around on it for whatever reason still won't get access to any advanced ammo types (not even the infernos that, other than the "intro"/"standard" divide, nothing historically would have ever stopped it from loading because those certainly stayed in common enough use).
That's why I personally leave Ammo & Equipment Limits permanently off as useless, which kind of defeats the purpose of having it. I'd suggest that if we want to enable the players to explicitly set their game's rules level, it (and possibly a couple of others) ought to be replaced with an option to simply do that instead; as said, we don't actually seem to have one like that just yet...
Thank you, Nick. And I apologize to write the two report in one.
I posted a feature request about this problem with "Ammo & Equipment Limits" for a reminder. Therefore, please close this bug report after the next release.
Also, thank you, Klaus for your comment to clarify this issue.
Thank you again.
Yea, I agree ith Klaus, I was thinking when looking at the code that we really should have a "Game Tech Level" setting much like we have "Game Year."
The issue with that is how it effects rules; we don't track what level the rules are. Probably what it should be is "Equipment Tech Level." Only equipment with the specified level or below is legal for the game.
I've also made adjustments to MekHQ's packaging scripts so that the OfficialUnitsList.txt is placed in the correct location as well. A previous change had all megamek and megameklab documents in subdirs of the docs dir. Now instead I've just had it rename the conflicting files (history.txt)