Menu

#40 use czipfile for ZIP support if available

SVN
closed-accepted
nobody
None
5
2015-12-03
2015-02-13
No

I just tested MComix with a password protected ZIP file, and it's extremely slow because the decryption is down entirely in Python. I'd like to commit this patch to take advantage of czipfile when available:

https://github.com/benoit-pierre/mcomix/compare/czipfile-support

Related

Bugs: #73

Discussion

  • Ark

    Ark - 2015-02-14

    Actually, I couldn't find the czipfile module in any of the Arch or Ubuntu repositories so I wonder how useful it really is for Linux users. However, since most downloaders of MComix use browsers that claim to run on Windows machines, it might be interesting for all the many users there (assuming that czipfile will appear in the all-in-one bundle for Windows).

    On the other hand, said repo issue for Linux-based systems is more like a chicken-and-egg problem and the patch doesn't seem to break things (if czipfile itself doesn't break things). Maybe I'll have a look at this in the next few days or Oddegamra might want to add one or two things.

     
  • Benoit Pierre

    Benoit Pierre - 2015-02-14

    Well, czipfile can easily be installed with pip on Linux, and the support is conditional. On Windows, an installer is available, and we could include it as part of the binary release.

    FYI, some benchmarks with and without it:

    • with czipfile: 3.82559204102 seconds
    • with zipfile: 424.119024992 seconds! (~7 minutes)

    (177Mo archive, with 149 entries)

     
  • Benoit Pierre

    Benoit Pierre - 2015-12-03
    • status: open --> closed-accepted
     

Log in to post a comment.

MongoDB Logo MongoDB