The 1.01 all in one windows version does not start. There are no error messages at all, the window simply does not appear. Downloaded the 1.00 version and everything works.
Exactly. win+x -> command line -> navigate to mcomix folder -> MComix.exe shows and empty line and returns to the command prompt. I can see the exe pop up for a second in task manager, it then goes away.
Win8.1 x64
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
OK, can you replace library.zip in the MComix folder with the attached one, and see if a MComix.exe.log is created?
Difference with the original file: I replaced one file (mcomix/portability.pyc), to disable a hack that remove stdout/stderr redirection to the MComix.exe.log file.
Actually, I like both ideas. My main concern regarding a hot-fixed version is that I can't tell which SVN revision is supposed to reflect the source code this hot-fixed version would be based on. Also, simply moving some compiled files around might break more things than it fixes. Despite that, I don't want to ask Oddegamra too often to test things.
Therefore, I prefer 1.2. However, we would need some help here, especially from you, Soukyuu: Could you please check whether the bug (or similar bugs) also appears in https://github.com/benoit-pierre/mcomix/tree/bpierre (the current head of the bpierre branch of the Github repository)?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The bug is a Python issue, it's independent of the version of MComix, but related to the environment used to generate the Windows distribution:
version 1.00 use Python 2.7.4
version 1.01 use Python 2.7.9
The bug is present in 2.7.9, and not 2.7.4.
So the hotfix would not be a new MComix version, but a new version of the Windows package.
On the subject of the Windows version, what I would not mind is for someone to test the package I generate with my script on a real Windows machine :).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
So the hotfix would not be a new MComix version, but a new version of the Windows package.
I see. So it would be a Windows-only rebuilt package version with no MComix source code changed.
On the subject of the Windows version, what I would not mind is for someone to test the package I generate with my script on a real Windows machine :).
@Benoit Pierre: Do you have an environment at hand where you could build an mcomix-1.01-2.win32.all-in-one.zip package? Maybe Soukyuu wouldn't mind testing it.
@Soukyuu: Thank you very much for reporting this bug. Would you mind testing a bit more? You would implicitly test the script Benoit Pierre made. The same script is supposed to build 1.2 so testing now might help us building 1.2, too.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
@Ark: sure, I can do some more testing. Are there instructions on building mcomix on windows somewhere? I used the archlinux mcomix-git aur package to build it on arch, but I have no idea on how to build it on windows.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
@Soukyuu: can you do another test with the attached library.zip? I changed mimetypes.pyc with the latest source from the Python Mercurial repository, as there was some recent changes related to this (https://hg.python.org/cpython/rev/bf2016a1911f), so this might already be fixed (and available in the next Python release).
@Soukyuu: Thank you very much. At the moment, for the proposed mcomix-1.01-2.win32.all-in-one.zip package, playing around a bit with the fixes Benoit Pierre introduces here should be already helpful. That is, open various archive formats (including RAR and PDF), open passworded archives, open images of various formats, navigate using various ways (space bar, PgDown/PgUp, Cursor keys, clicking on thumbnailer, etc), enter and leave fullscreen, use the library, zoom, use the "Enhance image" dialog, etc.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
One more thing: programs on windows are supposed to use the %appdata% folder to store their settings, so %appdata%\MComix in this case, not %homepath%\MComix as it does now.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
rotations work (though I expected double page to rotate two pages as one, not individually)
Agreed.
many strings seem to be stuck on localized ones even if using another language (see bug#85)
This one is really strange...
One more thing: programs on windows are supposed to use the %appdata% folder to store their settings, so %appdata%\MComix in this case, not %homepath%\MComix as it does now.
I see. That would be something like "C:\Documents and Settings\<user>\Application Data\Local Settings\MComix"</user> or "C:\Documents and Settings\<user>\Application Data\Mcomix"</user>, right? Maybe we should include a copy of appdirs, to use in place of the current code.
Back to the Windows package, would mind testing the version in attachment? It's generated using my script (which is Linux only, to answer your earlier question). It uses a different method for generating (pyinstaller instead of py2exe) and includes a few additional things:
It appears the new windows build does not have the localized strings issue anymore. All strings are in English now (interestingly, the British variant, judging by stuff like "Behaviour" and "colour").
PDF now works
pass protected .7z now shows a red X icon instead of saying no images. It does show 165 files, but no password prompt is displayed. Encrypting filenames additionally, shows "no image files" as before.
any reason you included both the 7z.exe and the .dll? Removing the .exe does not seem to change 7z behavior.
thumbnailer does not seem to work on 7z archives
if "start in fullscreen" is enabled, unticking rightclick->view->fullscreen has the same behavior as "hide all toolbars" (shortcut I) instead of leaving fullscreen. If started as windowed, both F and (un)ticking view->fullscreen behave the same.
image auto-rotation does not work still
rotations of double pages still don't rotate as one
RAR5 works now
Everything else seems to be working.
I see. That would be something like "C:\Documents and Settings\<user>\Application Data\Local Settings\MComix" or "C:\Documents and Settings\<user>\Application Data\Mcomix", right? Maybe we should include a copy of appdirs, to use in place of the current code.</user></user>
Actually, ever since vista the dirs are "C:\Users\<username>\Appdata\Local" for local settings and "C:\Users\<username>\Appdata\Roaming" for the roaming profile settings. I am not sure what the difference between those two is, but most applications store settings in the "\Roaming" folder. I think there is still some redirection for apps that use the old paths, but I wouldn't rely on it.</username></username>
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Just to clarify, the MComix version is the same as 1.01, the numbering change to 1.1 is for PEP compliance (easier to generate the package). I think the next MComix version will probably be numbered 1.2.
It appears the new windows build does not have the localized strings issue anymore. All strings are in English now (interestingly, the British variant, judging by stuff like "Behaviour" and "colour").
Okay.
any reason you included both the 7z.exe and the .dll? Removing the .exe does not seem to change 7z behavior.
It's needed by the executable. Don't you already have 7z installed? So the DLL is already present in your PATH.
I see. That would be something like "C:\Documents and Settings\<user>\Application Data\Local Settings\MComix" or "C:\Documents and Settings\<user>\Application Data\Mcomix", right? Maybe we should include a copy of appdirs, to use in place of the current code.</user></user>
Actually, ever since vista the dirs are "C:\Users\<username>\Appdata\Local" for local settings and "C:\Users\<username>\Appdata\Roaming" for the roaming profile settings. I am not sure what the difference between those two is, but most applications store settings in the "\Roaming" folder. I think there is still some redirection for apps that use the old paths, but I wouldn't rely on it.</username></username>
Right, the appdirs module seems to be handling this correctly then:
It's needed by the executable. Don't you already have 7z installed? So the DLL is already present in your PATH.
Yes, I have it installed. Did not know it was added to the PATH automatically on windows, but apparently it is. I'm taking it the 7z issues are because mcomix is using the .exe and not the .dll directly?
Thanks for testing!
You're welcome~
Last edit: Soukyuu 2015-04-14
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
So you tried starting it from the command line, and there are no errors?
Exactly. win+x -> command line -> navigate to mcomix folder -> MComix.exe shows and empty line and returns to the command prompt. I can see the exe pop up for a second in task manager, it then goes away.
Win8.1 x64
Anything in
MComix.exe.log?There is no such file created in the MComix directory. Checked %appdata% as well, but nothing MComix related there either.
OK, can you replace
library.zipin the MComix folder with the attached one, and see if aMComix.exe.logis created?Difference with the original file: I replaced one file (
mcomix/portability.pyc), to disable a hack that remove stdout/stderr redirection to theMComix.exe.logfile.Yes, this time a log is created, see attachment.
Progress! Apparently this is a Python bug: https://bugs.python.org/issue23371
Does using the attached library.zip fix the issue?
(I replaced
mimetypes.pycby the version from MComix-1.0)Yes, that fixes it.
@Ark: should we create a new
mcomix-1.01-2.win32.all-in-one.ziparchive with this patched library?..is 1.02 that far off? I'll stay on 1.00 for now anyway because of that auto-rotate bug I've reported before (bug#80)
Actually, I like both ideas. My main concern regarding a hot-fixed version is that I can't tell which SVN revision is supposed to reflect the source code this hot-fixed version would be based on. Also, simply moving some compiled files around might break more things than it fixes. Despite that, I don't want to ask Oddegamra too often to test things.
Therefore, I prefer 1.2. However, we would need some help here, especially from you, Soukyuu: Could you please check whether the bug (or similar bugs) also appears in https://github.com/benoit-pierre/mcomix/tree/bpierre (the current head of the
bpierrebranch of the Github repository)?The bug is a Python issue, it's independent of the version of MComix, but related to the environment used to generate the Windows distribution:
The bug is present in 2.7.9, and not 2.7.4.
So the hotfix would not be a new MComix version, but a new version of the Windows package.
On the subject of the Windows version, what I would not mind is for someone to test the package I generate with my script on a real Windows machine :).
I see. So it would be a Windows-only rebuilt package version with no MComix source code changed.
@Benoit Pierre: Do you have an environment at hand where you could build an
mcomix-1.01-2.win32.all-in-one.zippackage? Maybe Soukyuu wouldn't mind testing it.@Soukyuu: Thank you very much for reporting this bug. Would you mind testing a bit more? You would implicitly test the script Benoit Pierre made. The same script is supposed to build 1.2 so testing now might help us building 1.2, too.
The following steps can be done to create
mcomix-1.01-2.win32.all-in-one.zipwith the hotfix:mcomix-1.01.win32.all-in-one.ziplibrary.zipwith the one from my previous comment: https://sourceforge.net/p/mcomix/bugs/_discuss/thread/746bde1a/0b4b/attachment/library.zipmcomix-1.01-2.win32.all-in-one.zipThat's all there is to it.
@Ark: sure, I can do some more testing. Are there instructions on building mcomix on windows somewhere? I used the archlinux mcomix-git aur package to build it on arch, but I have no idea on how to build it on windows.
@Soukyuu: can you do another test with the attached
library.zip? I changedmimetypes.pycwith the latest source from the Python Mercurial repository, as there was some recent changes related to this (https://hg.python.org/cpython/rev/bf2016a1911f), so this might already be fixed (and available in the next Python release).@Soukyuu: Thank you very much. At the moment, for the proposed
mcomix-1.01-2.win32.all-in-one.zippackage, playing around a bit with the fixes Benoit Pierre introduces here should be already helpful. That is, open various archive formats (including RAR and PDF), open passworded archives, open images of various formats, navigate using various ways (space bar, PgDown/PgUp, Cursor keys, clicking on thumbnailer, etc), enter and leave fullscreen, use the library, zoom, use the "Enhance image" dialog, etc.@Benoit Pierre: the latest library.zip works fine, so I guess the fix is already in.
@Ark:
One more thing: programs on windows are supposed to use the %appdata% folder to store their settings, so %appdata%\MComix in this case, not %homepath%\MComix as it does now.
Thanks for the feedback.
You need the MuPDF tools for PDF support.
Looks like indeed the version included is not up-to-date.
Yeah, that's a known issue: password protected archive are not supported when using an external executable for decompression.
Correct, animations are not supported.
Agreed.
This one is really strange...
I see. That would be something like "C:\Documents and Settings\<user>\Application Data\Local Settings\MComix"</user> or "C:\Documents and Settings\<user>\Application Data\Mcomix"</user>, right? Maybe we should include a copy of appdirs, to use in place of the current code.
Back to the Windows package, would mind testing the version in attachment? It's generated using my script (which is Linux only, to answer your earlier question). It uses a different method for generating (pyinstaller instead of py2exe) and includes a few additional things:
@Benoit Pierre:
Everything else seems to be working.
Actually, ever since vista the dirs are "C:\Users\<username>\Appdata\Local" for local settings and "C:\Users\<username>\Appdata\Roaming" for the roaming profile settings. I am not sure what the difference between those two is, but most applications store settings in the "\Roaming" folder. I think there is still some redirection for apps that use the old paths, but I wouldn't rely on it.</username></username>
Just to clarify, the MComix version is the same as 1.01, the numbering change to 1.1 is for PEP compliance (easier to generate the package). I think the next MComix version will probably be numbered 1.2.
Okay.
It's needed by the executable. Don't you already have 7z installed? So the DLL is already present in your PATH.
Right, the appdirs module seems to be handling this correctly then:
Thanks for testing!
Yes, I have it installed. Did not know it was added to the PATH automatically on windows, but apparently it is. I'm taking it the 7z issues are because mcomix is using the .exe and not the .dll directly?
You're welcome~
Last edit: Soukyuu 2015-04-14
Correct.
I attached an
mcomix-1.01-2.win32.all-in-one.zipbased on https://sourceforge.net/p/mcomix/bugs/84/#3286.@Soukyuu: Please check whether the attached version works on Windows 8.1, again. (Just make sure that it starts without crashing.)
I will ask Oddegamra to test it for XP as well. If it works there and with 8.1, let us hope that the Windows versions between them work as well.