Thank you for working on this ticket. I am not sure about the new rotation semantics (albeit they look much more meaningful). What is the main use case for this "new" auto rotation feature you had (and still have) in mind?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Exif rotation make only sense on individual image, and is applied first, since it's the baseline for displaying the image correctly
automatic and manual rotations are applied on the whole page (single or double)
automatic rotation is applied before the manual rotation because the default is for the manual rotation to be temporary, and so it's easier from a user point of view to use it last, for example to temporarily change the result after the other automatic rotations
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thank you for the explanation, but either I just don't get it or the implementation does not always work as intended. From what I understand, both auto rotation and manual rotation are supposed to be applied to the union (instead of each image separately). If this is the case, then, for example, in the current implementation of the rotation branch, when I manually rotate the union of two pages (in double page mode) by 180 or 270 degrees CW in western mode, the images need to be swapped.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Note that the "Flip horizontally/vertically" transforms are still applied to individual images. I think it would make more sense to do it on the whole page too, no?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Also, while we are on the subject of double page mode, why the 2 pixels spacing between the images? If the 2 images are indeed 2 halves of the same page, then the vertical line between them is really ugly.
Last edit: Ark 2015-04-01
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Did you edit one of my comment instead of replying? I just noticed it from the "Project Activity" on the Sourceforge project page. (I was waiting for a reply on this, but never got any notification).
Last edit: Benoit Pierre 2015-04-01
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Oh, I indeed messed up. I am really sorry for that. I actually wanted to reply but accidentally edited the post I intended to copy from only. Thank you very much for notifying.
I just tried to restore the content. Thankfully, I had quoted the original post instead of rewriting it. Now everything looks more like it was supposed to look like in the first place. Below the next horizontal rule, you will find the "post" from 2015-03-24.
Note that the "Flip horizontally/vertically" transforms are still applied to individual images. I think it would make more sense to do it on the whole page too, no?
You are right. All transformations (except Exif, of course) should be applied consistently.
Also, while we are on the subject of double page mode, why the 2 pixels spacing between the images? If the 2 images are indeed 2 halves of the same page, then the vertical line between them is really ugly.
The gap is quite useful if the two pages are supposed to be read one after another. I know what you mean, though, as there are sometimes images splitted into two pages. I think we can make this optional (with customizable gap size), but this would be an issue for another release.
I tested the new implementation a bit. Result: Seems to work for western mode but is broken for manga mode.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Okay, I have a new version that should work in both modes. See this ticket [patches:#41], I just created for discussing the changes I have ready for inclusion.
Can you check if this branch works for you?
Yes, thank you. Both option work fine now.
@aaku: How about pushing those changes to SVN?
This fix:
get_implied_rotationsupport for PNG files: lookup up Exif data from tEXt chunkThe way the different rotations are applied is as follow:
Thank you for working on this ticket. I am not sure about the new rotation semantics (albeit they look much more meaningful). What is the main use case for this "new" auto rotation feature you had (and still have) in mind?
It's not new. The code was working in MComix 1.00, but not since 1.01.
As for the use case, see the original report.
Regarding the hew rotation semantics:
Thank you for the explanation, but either I just don't get it or the implementation does not always work as intended. From what I understand, both auto rotation and manual rotation are supposed to be applied to the union (instead of each image separately). If this is the case, then, for example, in the current implementation of the
rotationbranch, when I manually rotate the union of two pages (in double page mode) by 180 or 270 degrees CW in western mode, the images need to be swapped.You're right, testing with 2 identical images (those I added in test/files/images) was a bad idea! I pushed a fix.
Note that the "Flip horizontally/vertically" transforms are still applied to individual images. I think it would make more sense to do it on the whole page too, no?
Also, while we are on the subject of double page mode, why the 2 pixels spacing between the images? If the 2 images are indeed 2 halves of the same page, then the vertical line between them is really ugly.
Last edit: Ark 2015-04-01
Did you edit one of my comment instead of replying? I just noticed it from the "Project Activity" on the Sourceforge project page. (I was waiting for a reply on this, but never got any notification).
Last edit: Benoit Pierre 2015-04-01
Oh, I indeed messed up. I am really sorry for that. I actually wanted to reply but accidentally edited the post I intended to copy from only. Thank you very much for notifying.
I just tried to restore the content. Thankfully, I had quoted the original post instead of rewriting it. Now everything looks more like it was supposed to look like in the first place. Below the next horizontal rule, you will find the "post" from 2015-03-24.
You are right. All transformations (except Exif, of course) should be applied consistently.
The gap is quite useful if the two pages are supposed to be read one after another. I know what you mean, though, as there are sometimes images splitted into two pages. I think we can make this optional (with customizable gap size), but this would be an issue for another release.
I tested the new implementation a bit. Result: Seems to work for western mode but is broken for manga mode.
Okay, I have a new version that should work in both modes. See this ticket [patches:#41], I just created for discussing the changes I have ready for inclusion.
Related
Patches:
#41