Menu

#154 MComic keybinding not working on Gnome 49 (patch attached to address the issue)

Git
closed-fixed
nobody
None
5
2025-12-22
2025-12-22
glika
No

Since updating to Fedora 43 with Gnome 49 and Python 3.14, MComix default key binding is no longer working.

Steps to reproduce:

Steps:
1. Use Gnome 49 with the latest versions of GTK, GLib etc...
2. Open a comic file with MComix (git hash: d2e9eb1)
3. Press the Arrow-right key

Expected:
1. The next page of the comic file is shown

Actual result:
1. Nothing happens

The same issue happens with several other key bindings like Space, Arrow-left, Arrow-up, Arrow-down.

Root cause

This following test in the keybinding logic fails when an arrow keys are pressed when it should succeed:

if keybinding in self._binding_to_action:

Location: /mcomix/keybindings.py line 258 (git hash: d2e9eb1)

It seems to related to the type of the objects returned by Gtk.accelerator_parse(...).
These objects behave like tuples but for an unknown reason, when they are used as dict keys they cannot be compared with equivalent tuples.

Workaround
Convert the result from Gtk.accelerator_parse(...) into a proper tuple.
I attached a quick patch that makes existing keybindings work again.
But more testing is required for a proper fix.

1 Attachments

Discussion

  • glika

    glika - 2025-12-22

    Proposed merge request to solve this issue:
    https://sourceforge.net/p/mcomix/git/merge-requests/56/

     
  • Oddegamra

    Oddegamra - 2025-12-22

    Thank you for the report and your contribution! I have merged the pull request.

     
  • Oddegamra

    Oddegamra - 2025-12-22
    • status: open --> closed-fixed
     

Log in to post a comment.