#111 genemf.h #includes <endian.h> but not found

[Hanspeter Niederstrasser]

After 9d7733, genemf.h #includes <endian.h>, but that's not found on macOS (10.13):</endian.h>

cc -DHAVE_CONFIG_H -DI18N_DATADIR="/sw/share/fig2dev/i18n" -g -O2 -MT genemf.o -MD -MP -MF .deps/genemf.Tpo -c -o genemf.o genemf.c -I. -I../.. -I../../fig2dev -I/sw/include
In file included from genemf.c:85:
./genemf.h:33:10: fatal error: 'endian.h' file not found
#include <endian.h>
         ^~~~~~~~~~
1 error generated.

endian.h does exist, but it's found in <machine endian.h="">. The addition of endian.h seems to have been from an automated linter. I can remove the #include and fig2dev-3.2.8 builds successfully. What symbol was <endian.h> supposed to provide? Should it be #included inside an #ifdef guard for that symbol?</endian.h></machine>

[tkl]

It was an error to include endian.h. Commit [3897c8] fixes the issue, and removes endian.h. Unfortunately, this bug means that on MacOS, and probably BSD versions, release 3.2.8 does not build without manual intervention.

[Hanspeter Niederstrasser]

Thanks for the fix. Small enough fix that can be scripted for package maintainers. WFM after patching with 3897c8.

[tkl]

Closed with version 3.2.8a.