[Mc4j-cvs] SF.net SVN: mc4j: [586] trunk/mc4j/modules/ems/src/ems

[<gh...@us...>]

Revision: 586
          http://mc4j.svn.sourceforge.net/mc4j/?rev=586&view=rev
Author:   ghinkl
Date:     2008-03-13 09:28:42 -0700 (Thu, 13 Mar 2008)

Log Message:
-----------
Use child first classloader for jboss to avoid problems with jboss-common being in the system classpath... Get rid of the over eager tracking of history metric values

Modified Paths:
--------------
    trunk/mc4j/modules/ems/src/ems/org/mc4j/ems/connection/support/metadata/JBossConnectionTypeDescriptor.java
    trunk/mc4j/modules/ems/src/ems-impl/org/mc4j/ems/impl/jmx/connection/bean/attribute/DAttribute.java

Modified: trunk/mc4j/modules/ems/src/ems/org/mc4j/ems/connection/support/metadata/JBossConnectionTypeDescriptor.java
===================================================================
--- trunk/mc4j/modules/ems/src/ems/org/mc4j/ems/connection/support/metadata/JBossConnectionTypeDescriptor.java	2007-08-31 17:32:02 UTC (rev 585)
+++ trunk/mc4j/modules/ems/src/ems/org/mc4j/ems/connection/support/metadata/JBossConnectionTypeDescriptor.java	2008-03-13 16:28:42 UTC (rev 586)
@@ -75,7 +75,7 @@
     }
 
    public boolean isUseChildFirstClassLoader() {
-       return false; //true;
+       return true;
    }
 
 

Modified: trunk/mc4j/modules/ems/src/ems-impl/org/mc4j/ems/impl/jmx/connection/bean/attribute/DAttribute.java
===================================================================
--- trunk/mc4j/modules/ems/src/ems-impl/org/mc4j/ems/impl/jmx/connection/bean/attribute/DAttribute.java	2007-08-31 17:32:02 UTC (rev 585)
+++ trunk/mc4j/modules/ems/src/ems-impl/org/mc4j/ems/impl/jmx/connection/bean/attribute/DAttribute.java	2008-03-13 16:28:42 UTC (rev 586)
@@ -169,10 +169,10 @@
             }
             // This old way stored attribute values if they were under a certain size
 //            if (com.vladium.utils.ObjectProfiler.sizeof(newValue) < 200)
+//            Don't do this if you're not going to bound it or have a way to disable it
+//            if (newValue instanceof Number)
+//                valueHistory.addValue(new Value(newValue, System.currentTimeMillis()));
 
-            if (newValue instanceof Number)
-                valueHistory.addValue(new Value(newValue, System.currentTimeMillis()));
-
             currentValue = newValue;
         }
     }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.