Re: [matplotlib-devel] custom symbol patch

[John H. <jdh...@ac...>]

>>>>> "Manuel" == Manuel Metz <mm...@as...> writes:

    Manuel> John Hunter wrote:
    >>>>>>> "Manuel" == Manuel Metz <mm...@as...> writes:
    >>
    Manuel> Hi, I just submitted a patch to sourceforge and also
    Manuel> attached it to this email:
    >>
    Manuel> The applied patch modifies the files axes.py and
    Manuel> collections.py.
    >>
    Manuel> I added a class StaredRegularPolyCollection() to
    Manuel> collections.py to create star-like regular Polygons.
    >>  This looks very useful -- thanks for the patch.  To questions:
    >> 
    >> What does the name "StaredRegularPolygon" mean?  I am having
    >> trouble figuring out the Stared part.

    Manuel> Argh - okay - this is a mistranslation from german to
    Manuel> english - sorry. I wanted to say "starlike". So probably
    Manuel> StarlikeRegularPolygon is a better name...

OK, I see.  Perhaps we should just call it a StarPolygonCollection
http://en.wikipedia.org/wiki/Star_polygon

Also, in your patch, unless I am missing something, it looks like you
could simply do something like

        scale = 0.5/math.sqrt(math.pi)  
        r = scale*ones(self.numsides*2)

rather than

+        r = 1.0/math.sqrt(math.pi)  # unit area
+        r = asarray( [r]*(self.numsides*2) ) 
+        for i in xrange(1,len(r),2):
+            r[i] *= 0.5

Ie, do everything in numerix, rather than in python.

When you get all of this incorporated, if you could send one patch
against svn that includes all of the changes I'll check it in (if
noone else has any corrections or comments).

Thanks again,
JDH