From: Nelle V. <nel...@gm...> - 2013-07-18 13:47:38
|
On 18 July 2013 15:27, Michael Droettboom <md...@st...> wrote: > On 07/17/2013 04:57 PM, Eric Firing wrote: > > On 2013/07/17 3:14 AM, Michael Droettboom wrote: > >> Yes. This is great work! > >> > >> Just to chime in (after having been away for most of this conversation) > --> > >> > >> I think we can do this reorganization now without introducing any > >> implicit (or otherwise) use of gca()/pyplot stuff in the Axes class > >> methods. Refactoring how the pyplot wrapper is done can be done as a > >> separate project at a later time (or even in parallel if someone wants > >> to, since all of Nelle's work at the end of the day doesn't change the > >> Axes interface). > >> > >> My only other comment (and I mentioned this in PR #2213 as well) is that > >> having the short stub functions in the Axes class in addition to the > >> actual implementations elsewhere introduces a new > >> synchronization/maintenance problem between the two. Maybe it makes > >> sense to merely add the implementation functions to the Axes class > >> namespace dynamically. Magical, sure, but should have ultimately the > >> same result as far as introspection, autocompletion and other IPython > >> goodness is concerned. > >> > >> Mike > > Mike, > > > > One other option is to have the new private modules include mixin > > classes from which Axes would inherit methods. There would be a lot of > > mixins, and this would be an example of the dreaded multiple > > inheritance, but it would be simple and explicit, with no magic. > > > > Eric > > > > > I think either approach is fine as far as I'm concerned, though what > Eric suggests is probably a bit simpler in terms of lines of code. > I'm attempting an implementation of https://github.com/matplotlib/matplotlib/pull/2213 using mixins, to get my head around this idea. I'll keep you posted on the code. > > Mike > > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > Matplotlib-devel mailing list > Mat...@li... > https://lists.sourceforge.net/lists/listinfo/matplotlib-devel > |