From: Benjamin R. <ben...@ou...> - 2012-11-16 13:40:41
|
On Fri, Nov 16, 2012 at 7:44 AM, Mike Kaufman <mc...@gm...> wrote: > On 11/15/12 2:54 PM, Paul Ivanov wrote: > > On Wed, Nov 14, 2012 at 7:37 PM, Mike Kaufman <mc...@gm... > > > > > I just found that *direction* accepts 'inout' as well, which > > does indeed place the tick on both sides of the spine. So the > > documentation should be updated to reflect this. > > > > > > Thanks for the report, Mike, here's a PR for the patch: > > https://github.com/matplotlib/matplotlib/pull/1503 > > > > If it were me, I'd allow 'both' to work as well. > > > > > > I'm amenable to that, just not sure if that counts as a new feature and > > should go into master, or a bugfix and go into v1.2.x. > > > > I can add this functionality to #1503 if that makes sense to go to v1.2.x > > Thanks Paul, > > One is a doc fix, the other requires changing code (inside axis.py?). So > best practice probably argues that 'both', if acceptable, should really > only go into master. > > That said, I think the 'both' change only requires a change to a pair of > conditionals... > > M > > I agree with the fact that implementing "both" to mean the same as "inout" should go into master only. Ben Root |